Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(frontend)[Age 1243]: Variant details fails to open after updating a variant #2236

Merged
merged 1 commit into from
Nov 10, 2024
Merged

(frontend)[Age 1243]: Variant details fails to open after updating a variant #2236

merged 1 commit into from
Nov 10, 2024

Conversation

bekossy
Copy link
Member

@bekossy bekossy commented Nov 9, 2024

Closes AGE-1243

@bekossy bekossy requested review from mmabrouk and jp-agenta November 9, 2024 13:29
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 9, 2024
@vercel Vercel
Copy link

vercel bot commented Nov 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 9, 2024 1:34pm
agenta-documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 9, 2024 1:34pm

@dosubot dosubot bot added bug Something isn't working Frontend labels Nov 9, 2024
mmabrouk
mmabrouk requested changes Nov 10, 2024
View reviewed changes
Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bekossy !

I have tested the feature and the problem has been resolved.

The cypress tests however have failed. I am rerunning them for now, maybe they get resolved by themselves (the issue seemed unrelated to your work).

mmabrouk
mmabrouk approved these changes Nov 10, 2024
View reviewed changes
Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works :)

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 10, 2024
@mmabrouk mmabrouk merged commit 740919c into feature/observability-checkpoint-2 Nov 10, 2024
6 checks passed
@mmabrouk mmabrouk deleted the AGE-1243/-variant-details-fails-to-open-after-updating-a-variant branch November 10, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmabrouk mmabrouk mmabrouk approved these changes

@jp-agenta jp-agenta Awaiting requested review from jp-agenta

Assignees
No one assigned
Labels
bug Something isn't working Frontend lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bekossy @mmabrouk