Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(frontend)[AGE-1011]: Solve size modal issue #2246

Merged
merged 9 commits into from
Nov 21, 2024
Merged

(frontend)[AGE-1011]: Solve size modal issue #2246

merged 9 commits into from
Nov 21, 2024

Conversation

bekossy
Copy link
Member

@bekossy bekossy commented Nov 11, 2024

Closes AGE-1011

@bekossy bekossy requested a review from mmabrouk November 11, 2024 17:13
@vercel Vercel
Copy link

vercel bot commented Nov 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 1:34am
agenta-documentation 🛑 Canceled (Inspect) Nov 21, 2024 1:34am

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. Frontend labels Nov 11, 2024
@bekossy bekossy changed the title (frontend)[AGE-1011]: Improvements to evaluation configuration UI (frontend)[AGE-1011]: Solve size modal issue Nov 11, 2024
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Nov 14, 2024
@dosubot dosubot bot removed the size:S This PR changes 10-29 lines, ignoring generated files. label Nov 21, 2024
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 21, 2024
mmabrouk
mmabrouk approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bekossy !
Tested and QA'ed

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 21, 2024
@mmabrouk mmabrouk merged commit 5e186e8 into main Nov 21, 2024
9 checks passed
@mmabrouk mmabrouk deleted the AGE-1011/-solve-size-modal-issue branch November 21, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmabrouk mmabrouk mmabrouk approved these changes

Assignees
No one assigned
Labels
Frontend lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bekossy @mmabrouk