Litellm patch #2254
Merged
Litellm patch #2254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix missing outputs
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
the
size:M
mmabrouk
requested changes
Nov 14, 2024
| @@ -89,16 +89,20 @@ def log_stream_event( | |||
| log.error("LiteLLM callback error: span not found.") | |||
| return | |||
|
|
|||
| result = kwargs.get("complete_streaming_response") | |||
There was a problem hiding this comment.
It does not look like you can remove this. It seems they get the result from there in the case of streaming, no?
| @@ -194,16 +198,20 @@ async def async_log_stream_event( | |||
| log.error("LiteLLM callback error: span not found.") | |||
| return | |||
|
|
|||
| result = kwargs.get("complete_streaming_response") | |||
mmabrouk
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
Thanks @jp-agenta
Reviewed and QA'ed
As for streaming:
- I added a test for streaming
- Apparently the log_success gets called anyways with streaming, so no need to log each event (each chunk). I have just removed it.
- However, all the code in the case of streaming works, it returns strange warnings
Setting attribute on ended span.
Setting attribute on ended span.
Tried calling set_status on an ended span.
Calling end() on an ended span.
I don't understand the reason. Although the sucess_event is working and logging everything correctly, somehow the otel sdk is saying we are calling things on ended spans. Not a blocker anyways (happens only in streaming)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.