Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] clean up agenta-cli dependencies #2267

Merged
merged 4 commits into from
Nov 19, 2024

Conversation

jp-agenta
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Nov 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2024 7:45pm
agenta-documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2024 7:45pm

Copy link

vercel bot commented Nov 19, 2024

Deployment failed with the following error:

Resource is limited - try again in 28 minutes (more than 100, code: "api-deployments-free-per-day").

@mmabrouk mmabrouk marked this pull request as ready for review November 19, 2024 16:51
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. CLI dependencies Pull requests that update a dependency file labels Nov 19, 2024
Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jp-agenta lgtm:

What I have done:

  • Searched for any instance of the removed packages in the code -> None found
  • Created a new environement with poetry and tried agenta init and agenta variant serve for sanity check -> works fine

Risks:

  • Deleted dependencies might be still installed in my system and used. However, seeing that the CI is working, this strongly suggests everything is working fine

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 19, 2024
@jp-agenta jp-agenta merged commit fdc0e82 into main Nov 19, 2024
6 of 9 checks passed
@jp-agenta jp-agenta deleted the chore/clean-up-agenta-cli-dependencies branch November 19, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI dependencies Pull requests that update a dependency file lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants