Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feautre] Add custom redact functionality to SDK #2269

Merged
merged 3 commits into from
Nov 19, 2024
Merged

[Feautre] Add custom redact functionality to SDK #2269

merged 3 commits into from
Nov 19, 2024

Conversation

jp-agenta
Copy link
Contributor

QA

  • see agenta/agenta-cli/tests/redact/...

@vercel Vercel
Copy link

vercel bot commented Nov 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 4:27pm
agenta-documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 4:27pm

jp-agenta
jp-agenta commented Nov 15, 2024
View reviewed changes
agenta-cli/agenta/__init__.py
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly

  • cleaning up dirty code from previous PRs
  • passing down redact and redact_on_error

jp-agenta
jp-agenta commented Nov 15, 2024
View reviewed changes
agenta-cli/agenta/sdk/agenta_init.py
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly

  • cleaning up dirty code from previous PRs
  • passing down redact and redact_on_error

jp-agenta
jp-agenta commented Nov 15, 2024
View reviewed changes
agenta-cli/agenta/sdk/decorators/tracing.py
Copy link
Contributor Author

@jp-agenta jp-agenta Nov 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is where instrument-specific redact is stored and where things happen.

jp-agenta
jp-agenta commented Nov 15, 2024
View reviewed changes
agenta-cli/agenta/sdk/tracing/tracing.py
Copy link
Contributor Author

@jp-agenta jp-agenta Nov 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is where cross-instrument redact is stored

@jp-agenta jp-agenta requested a review from mmabrouk November 15, 2024 23:18
@jp-agenta jp-agenta marked this pull request as ready for review November 15, 2024 23:18
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. feature SDK tests labels Nov 15, 2024
mmabrouk
mmabrouk reviewed Nov 18, 2024
View reviewed changes
Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jp-agenta Thanks for the PR, it would be great if you could update the SDK howto observability to add a short section on how to redact information with a short example

@jp-agenta
Copy link
Contributor Author

@jp-agenta Thanks for the PR, it would be great if you could update the SDK howto observability to add a short section on how to redact information with a short example

@mmabrouk -- added docs.

mmabrouk
mmabrouk approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jp-agenta !
Reviewed and QA'ed

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 19, 2024
@mmabrouk mmabrouk merged commit ee9769a into main Nov 19, 2024
9 of 10 checks passed
@mmabrouk mmabrouk deleted the feature/allow-custom-redact branch November 19, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmabrouk mmabrouk mmabrouk approved these changes

Assignees
No one assigned
Labels
feature lgtm This PR has been approved by a maintainer SDK size:L This PR changes 100-499 lines, ignoring generated files. tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jp-agenta @mmabrouk