[Fix] AGE-1360 #2285
Merged
[Fix] AGE-1360 #2285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jp-agenta
commented
Nov 21, 2024
| @@ -41,7 +41,7 @@ def _is_uuid_key(key: str) -> bool: | |||
| "root.id", | |||
| "tree.id", | |||
| "node.id", | |||
| "parend.id", | |||
| "parent.id", | |||
There was a problem hiding this comment.
Independent fix.
jp-agenta
commented
Nov 21, 2024
| @@ -152,6 +152,7 @@ def parse_ingest_value( | |||
| attributes[key] = to_type(attributes[key]) | |||
| except ValueError: | |||
| print_exc() | |||
| print(f"key='{key}' attribute='{attributes[key]}' type='{to_type}'") | |||
There was a problem hiding this comment.
Simply more info for future debugging of things like badly formed hexadecimal UUID string
jp-agenta
commented
Nov 21, 2024
| @@ -167,7 +168,7 @@ def parse_ingest( | |||
| } | |||
| for field, attributes in typecheck.items(): | |||
| if attributes is not None: | |||
| for key in attributes.keys(): | |||
| for key in list(attributes.keys()): | |||
There was a problem hiding this comment.
Prevents dictionary changed size during iteration
mmabrouk
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.