Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Fix]: Resolve CLI commands failing tests #2299

Merged
merged 4 commits into from
Nov 25, 2024
Merged

[Bug Fix]: Resolve CLI commands failing tests #2299

merged 4 commits into from
Nov 25, 2024

Conversation

aybruhm
Copy link
Member

@aybruhm aybruhm commented Nov 25, 2024 •
edited
Loading

Description

This PR updates the CLI commands workflow to set the working directory to examples/deprecated_sdk_v2/.

@vercel Vercel
Copy link

vercel bot commented Nov 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2024 11:45am
agenta-documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2024 11:45am

@aybruhm aybruhm marked this pull request as ready for review November 25, 2024 11:01
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. bug Something isn't working CLI labels Nov 25, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Nov 25, 2024
mmabrouk
mmabrouk approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for resolving this @aybruhm I made that change but did not expect it to be related to our tests
Can you please create an issue to move the test apps to a proper test folder.
These are not supposed to be test apps. Only examples. (cc @aakrem )

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 25, 2024
@mmabrouk mmabrouk merged commit 32dfe6e into main Nov 25, 2024
10 of 12 checks passed
@mmabrouk mmabrouk deleted the resolve-failing-cli-commands-workflow branch November 25, 2024 12:05
@aybruhm
Copy link
Member Author

aybruhm commented Nov 25, 2024

Thank you for resolving this @aybruhm I made that change but did not expect it to be related to our tests Can you please create an issue to move the test apps to a proper test folder. These are not supposed to be test apps. Only examples. (cc @aakrem )

Yes, will do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmabrouk mmabrouk mmabrouk approved these changes

Assignees
No one assigned
Labels
bug Something isn't working CLI lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aybruhm @mmabrouk