(frontend)[AGE-1393]: Update create new evaluation modal with new design #2337
Conversation
…evaluator, testset and variant sections
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…wEvaluation for clearer context
dosubot
bot
added
size:XXL
There was a problem hiding this comment.
Thanks @bekossy
Here is my review:
- Selecting the test case should collapse the first collapsible, since anyways the user can select only one
- When you uncollapse any collapsible it uncollapses in two speeds. One along the table and a second speed for the empty space (see video)
- Not sure about this one, please check with Ahmed, but if I have only variant why do I need so much empty space in the collapsible
https://github.com/user-attachments/assets/594e0bed-977e-4a1d-a59e-61b121236f1f - Size don't match (see next comment)
- Advanced config button update
- E2E tests failing
@ardaerzin can you please review the code
|
|
agenta-web/src/components/pages/evaluations/NewEvaluation/SelectEvaluatorSection.tsx
Outdated
Show resolved
Hide resolved
agenta-web/src/components/pages/evaluations/NewEvaluation/SelectVariantSection.tsx
Outdated
Show resolved
Hide resolved
agenta-web/src/components/pages/evaluations/NewEvaluation/SelectVariantSection.tsx
Outdated
Show resolved
Hide resolved
agenta-web/src/components/pages/evaluations/NewEvaluation/SelectTestsetSection.tsx
Outdated
Show resolved
Hide resolved
agenta-web/src/components/pages/evaluations/NewEvaluation/SelectEvaluatorSection.tsx
Outdated
Show resolved
Hide resolved
|
@bekossy it feels a little weird to have 1 modal that closes when mask is clicked, next to another one that doesn't. I think we should keep the behavior consistent. I see the evaluators modal got that behavior disabled recently, might make sense to mimic that behavior in this one too |
…t antd collapse components, fixed search input button size and removed fixed height from collapse content
…sk and code clean
|
@bekossy lgtm, only minor comment. The model columns seems not to be working. Let's either get it to work or remove it. Other than that, ready to merge |
| {...props} | ||
| className={classes.collapseContainer} | ||
| activeKey={activePanel === "variantPanel" ? "variantPanel" : undefined} | ||
| onChange={() => handlePanelChange("variantPanel")} | ||
| items={[ |
There was a problem hiding this comment.
Sorry if I wasn't clear on the first review. What I meant before was memoization of the items array that are passed to collapsed components. As we saw during the call, using that practice will also bring performance updates during collapse ui state changes. 🙏
mmabrouk
deleted the
AGE-1393/-update-create-new-evaluation-modal-with-new-design
branch
Closes AGE-1393