Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Display a "Not Optimized for Mobile" overlay to users trying to access Agenta app from browsers with narrow width #2339

Merged

Conversation

ardaerzin
Copy link
Contributor

closes AGE-1407

What has changed?

  • new component has been created to display a message to users accessing Agenta from browsers with narrow viewports.

What else?

  • minor improvement to the shared useResizeObserver hook so that it can observe an element passed as an argument. Useful to observe window size changes

Copy link

vercel bot commented Dec 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2024 3:32pm
agenta-documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2024 3:32pm

Copy link

sentry-io bot commented Dec 5, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: agenta-web/src/pages/_app.tsx

Function Unhandled Issue
App TypeError: Cannot destructure property 'Component' of 'undefined' as it is undefined. GET /_next/static/chunks/pa...
Event Count: 3 Affected Users: 0

Did you find this useful? React with a 👍 or 👎

@ardaerzin ardaerzin requested review from ashrafchowdury and bekossy and removed request for ashrafchowdury December 5, 2024 13:30
@ardaerzin ardaerzin marked this pull request as ready for review December 5, 2024 13:30
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. typescript UI labels Dec 5, 2024
@mmabrouk
Copy link
Member

mmabrouk commented Dec 5, 2024

Thank you @ardaerzin . I have QA'ed this and it works fine!

Copy link
Collaborator

@ashrafchowdury ashrafchowdury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @ardaerzin.

LGTM!

@mmabrouk mmabrouk merged commit 9140212 into main Dec 6, 2024
9 checks passed
@mmabrouk mmabrouk deleted the AGE-1407/feat-add-not-optimized-warning-for-small-screens branch December 6, 2024 08:06
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files. typescript UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants