Update evaluators_service.py #2347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
using `is not None` checks instead of truthy checks, which is more explicit and correct for boolean values. truthy checks fails in the case of `ground_truth_value` and `llm_app_output_value` both equal to a valid False value
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@morenobonaventura is attempting to deploy a commit to the agenta projects Team on Vercel. A member of the Team first needs to authorize it. |
dosubot
bot
added
the
size:XS
mmabrouk
approved these changes
Dec 6, 2024
|
@all-contributors please add @morenobonaventura for bug fix |
|
I've put up a pull request to add @morenobonaventura! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using
is not Nonechecks instead of truthy checks, which is more explicit and correct for boolean values.truthy checks fails in the case of
ground_truth_valueandllm_app_output_valueboth equal to a valid False value