[Enhancement]: Add fail-safe logic to compute duration when running evaluations #2351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…case of a missing attribute
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
size:S
jp-agenta
approved these changes
Dec 9, 2024
jp-agenta
deleted the
feature/age-1448-sdk-x-evaluations-missing-metrics-attribute-in-spandto
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves an issue where evaluations fail in
cloud.betadue to a missingmetricsattribute in theSpanDTO. The issue stemmed from the templates using an outdated version of the SDK, which prevented the computation of duration and latency for evaluation runs, leading to errors.The templates have been updated to use the latest SDK version. Additionally, a fail-safe logic has been implemented to compute the duration using the
TimeDTO, ensuring evaluations can proceed without errors even if themetricsattribute is unavailable.Related Issue
Closes AGE-1448