delete dataset #42
Merged
delete dataset #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmabrouk
approved these changes
May 31, 2023
| import { ColumnsType } from 'antd/es/table'; | ||
| import { useState, useEffect } from 'react'; | ||
| import { formatDate } from '@/lib/helpers/dateTimeHelper'; | ||
| import { DeleteOutlined } from "@ant-design/icons"; |
There was a problem hiding this comment.
until now, we've been using the components for all the logic and the pages only as a wrapper. This goes against this. I propose instead to have this as a components (maybe under datasetPage or something like this). Or, we start having all the app logic in the pages, but I think we should be consistent
There was a problem hiding this comment.
I have been looking at how some complex apps have been done. I think it's worth looking at:
https://github.com/makeplane/plane/tree/develop/apps/app
https://github.com/dailydotdev/apps/tree/main/packages/shared
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.