Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache build stages #13

Closed
wants to merge 6 commits into from
Closed

cache build stages #13

wants to merge 6 commits into from

Conversation

turadg
Copy link
Member

@turadg turadg commented Nov 6, 2023

Before

https://github.com/Agoric/agoric-3-proposals/actions/runs/6775971345/job/18416450836

Job Time
build test images 49.8 min
run test images 2.5 min
Build and push complete image 0.5 min

After
https://github.com/Agoric/agoric-3-proposals/actions/runs/6776139160/job/18416966447

Job Time
build test images 59.5 min
run test images 3.9 min
Build and push complete image 0.8 min

Slower across the board. I don't know if it's just CI weather or the caching IO slowed things down. It's definitely being written to!

❯ gh api \
  -H "Accept: application/vnd.github+json" \
  -H "X-GitHub-Api-Version: 2022-11-28" \
  /repos/agoric/agoric-3-proposals/actions/cache/usage
{
  "full_name": "Agoric/agoric-3-proposals",
  "active_caches_size_in_bytes": 19244682819,
  "active_caches_count": 349
}

Second run with caching enabled

https://github.com/Agoric/agoric-3-proposals/actions/runs/6776896609/job/18419392914

Sadly, it's still running start_to_to.sh. I think the solution may require explicit cache management and invalidation. E.g. don't re-build tests that haven't been touched.

buildTestImages.ts Outdated Show resolved Hide resolved
@turadg turadg force-pushed the 2-cache branch 5 times, most recently from a90b1e1 to 99027c0 Compare November 9, 2023 19:31
@turadg turadg force-pushed the 2-cache branch 3 times, most recently from a403665 to b7d41b0 Compare November 9, 2023 22:50
@turadg
Copy link
Member Author

turadg commented Jan 26, 2024

Come back to this now that it builds with bake
docker/bake-action#36 (comment)

@turadg turadg closed this Feb 7, 2024
@turadg turadg deleted the 2-cache branch March 19, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant