Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade 13 #47

Merged
merged 3 commits into from
Jan 5, 2024
Merged

Upgrade 13 #47

merged 3 commits into from
Jan 5, 2024

Conversation

mhofman
Copy link
Member

@mhofman mhofman commented Dec 15, 2023

Closes #51

Adds a proposal for the upcoming upgrade-13. Using a proposal number as I need this to be included in the tag generated for the PR to get Agoric/agoric-sdk#8593 passing.

Includes a couple refactors to move common helpers into the shared library.

@mhofman mhofman requested a review from turadg December 15, 2023 03:14
Copy link
Member

@turadg turadg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adds a proposal for the upcoming upgrade-13.

To get a number in this repo's main, the proposal must have passed in https://bigdipper.live/agoric/proposals

I'll review again once the proposal has passed.

Using a proposal number as I need this to be included in the tag generated for the PR to get Agoric/agoric-sdk#8593 passing.

I take it the production of the PR's image means you're not blocked on this being in master.

Includes a couple refactors to move common helpers into the shared library.

Given how this build is factored now, those changes invalidate the base image. I'm reluctant to accept them because it will cause each developer's machine to have to rebuild for an hour to get them. This is part of the motivation for proposal package imports versioning in #46

@mhofman
Copy link
Member Author

mhofman commented Jan 5, 2024

Given how this build is factored now, those changes invalidate the base image. I'm reluctant to accept them because it will cause each developer's machine to have to rebuild for an hour to get them. This is part of the motivation for proposal package imports versioning in #46

@turadg before I merge, I realize I didn't address your feedback about the refactor this PR does. Are there still concerns with causing the images to rebuild on developers machines?

@turadg
Copy link
Member

turadg commented Jan 5, 2024

Are there still concerns with causing the images to rebuild on developers machines?

Thanks for asking. It has the same impact but at this point I don't expect anyone to update to master on the local branches until refactoring to use the @agoric/synthetic-chain package (#46) so I don't think it's worth your time to back out the changes. They're also an improvement so I'll incorporate into the refactoring.

@mhofman mhofman merged commit ab2422a into main Jan 5, 2024
1 check passed
@mhofman mhofman deleted the mhofman/upgrade-13 branch January 5, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add #65 Upgrade to agoric-upgrade-13
2 participants