feat(synthetic-chain): add proposal upgradeInfo support #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turadg
approved these changes
Jan 13, 2024
| @@ -42,6 +43,10 @@ function readInfo(proposalPath: string): ProposalInfo { | |||
| }; | |||
| } | |||
|
|
|||
| export function encodeUpgradeInfo(upgradeInfo: unknown): string { | |||
| return upgradeInfo != null ? JSON.stringify(upgradeInfo) : ''; | |||
There was a problem hiding this comment.
Nit: swap the expressions so the condition isn't negated, or better yet no ternary
There was a problem hiding this comment.
Sorry, I forgot about this before publishing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plumbing of
UPGRADE_INFOseem to have disappeared withsynthetic-chain. This adds the capability back.Manually tested in
agoric-sdkwith a core proposal installing the network vat on top of Agoric/agoric-sdk#8747Released as 0.0.3