Add support for iavl options in cosmos config (#9426)

closes: #9424

## Description

Plumb the iavl options into the cosmos baseapp.

Copied by comparing to `DefaultBaseappOptions` in cosmos-sdk
`server/util.go`, which we should likely use directly instead (see
#9425), but this is a minimal change we can easily adopt now.

### Security Considerations

None

### Scaling Considerations

None

### Documentation Considerations

None. Change should explicitly be part of the release notes

### Testing Considerations

Unsure about how to test this

### Upgrade Considerations

Chain software, not consensus affecting.

golang/cosmos/daemon/cmd/root.go

@@ -323,6 +323,9 @@ func (ac appCreator) newApp(
 		baseapp.SetTrace(cast.ToBool(appOpts.Get(server.FlagTrace))),
 		baseapp.SetIndexEvents(cast.ToStringSlice(appOpts.Get(server.FlagIndexEvents))),
 		baseapp.SetSnapshot(snapshotStore, snapshotOptions),
+		baseapp.SetIAVLCacheSize(cast.ToInt(appOpts.Get(server.FlagIAVLCacheSize))),
+		baseapp.SetIAVLDisableFastNode(cast.ToBool(appOpts.Get(server.FlagDisableIAVLFastNode))),
+		baseapp.SetIAVLLazyLoading(cast.ToBool(appOpts.Get(server.FlagIAVLLazyLoading))),
 	)
 }
 

golang/cosmos/daemon/cmd/root_test.go

@@ -1,13 +1,24 @@
 package cmd_test
 
 import (
+	"bytes"
+	"io"
+	"os"
 	"testing"
+	"text/template"
 
+	"github.com/spf13/pflag"
+	"github.com/stretchr/testify/require"
+
+	"github.com/cosmos/cosmos-sdk/server"
 	svrcmd "github.com/cosmos/cosmos-sdk/server/cmd"
+	serverconfig "github.com/cosmos/cosmos-sdk/server/config"
+	servertypes "github.com/cosmos/cosmos-sdk/server/types"
+	"github.com/tendermint/tendermint/libs/log"
+	dbm "github.com/tendermint/tm-db"
 
 	app "github.com/Agoric/agoric-sdk/golang/cosmos/app"
 	"github.com/Agoric/agoric-sdk/golang/cosmos/daemon/cmd"
-	"github.com/stretchr/testify/require"
 )
 
 func TestRootCmdConfig(t *testing.T) {
@@ -21,3 +32,180 @@ func TestRootCmdConfig(t *testing.T) {
 
 	require.NoError(t, svrcmd.Execute(rootCmd, "", app.DefaultNodeHome))
 }
+
+func TestCLIFlags(t *testing.T) {
+	// List of flags we have so far observed as used by the base cosmos sdk
+	// Before adding any flag to this list, the author should audit if explicit
+	// handling should not be added in the Agoric app (most likely in root.go)
+	expectedFlagNames := map[string]interface{}{
+		"abci":                  "",
+		"abci-client-type":      "",
+		"address":               "",
+		"app-db-backend":        "",
+		"cpu-profile":           "",
+		"db_backend":            "",
+		"db_dir":                "",
+		"fast_sync":             "",
+		"genesis_hash":          "",
+		"grpc-only":             "",
+		"halt-height":           "",
+		"halt-time":             "",
+		"home":                  "",
+		"iavl-cache-size":       "",
+		"iavl-disable-fastnode": "",
+		"iavl-lazy-loading":     "",
+		"index-events":          "",
+		"inter-block-cache":     "",
+		"inv-check-period":      "",
+		"min-retain-blocks":     "",
+		"minimum-gas-prices":    "",
+		"moniker":               "",
+		"priv_validator_laddr":  "",
+		"proxy_app":             "",
+		"pruning":               "default",
+		"pruning-interval":      "",
+		"pruning-keep-recent":   "",
+		"trace":                 "",
+		"trace-store":           "",
+		"transport":             "",
+		"unsafe-skip-upgrades":  "",
+		"with-tendermint":       "",
+
+		"api.address":              "",
+		"api.enable":               "",
+		"api.enabled-unsafe-cors":  "",
+		"api.max-open-connections": "",
+		"api.rpc-max-body-bytes":   "",
+		"api.rpc-read-timeout":     "",
+		"api.rpc-write-timeout":    "",
+		"api.swagger":              "",
+
+		"consensus.create_empty_blocks":          "",
+		"consensus.create_empty_blocks_interval": "",
+		"consensus.double_sign_check_height":     "",
+
+		"grpc-web.address":            "",
+		"grpc-web.enable":             "",
+		"grpc-web.enable-unsafe-cors": "",
+
+		"grpc.address":           "",
+		"grpc.enable":            "",
+		"grpc.max-recv-msg-size": "",
+		"grpc.max-send-msg-size": "",
+
+		"p2p.external-address":       "",
+		"p2p.laddr":                  "",
+		"p2p.persistent_peers":       "",
+		"p2p.pex":                    "",
+		"p2p.private_peer_ids":       "",
+		"p2p.seed_mode":              "",
+		"p2p.seeds":                  "",
+		"p2p.unconditional_peer_ids": "",
+		"p2p.upnp":                   "",
+
+		"rpc.grpc_laddr":  "",
+		"rpc.laddr":       "",
+		"rpc.pprof_laddr": "",
+		"rpc.unsafe":      "",
+
+		"rosetta.address":               "",
+		"rosetta.blockchain":            "",
+		"rosetta.denom-to-suggest":      "",
+		"rosetta.enable-fee-suggestion": "",
+		"rosetta.enable":                "",
+		"rosetta.gas-to-suggest":        "",
+		"rosetta.network":               "",
+		"rosetta.offline":               "",
+		"rosetta.retries":               "",
+
+		"state-sync.snapshot-interval":    "",
+		"state-sync.snapshot-keep-recent": "",
+
+		"store.streamers": "",
+
+		"streamers.file.fsync":              "",
+		"streamers.file.keys":               "",
+		"streamers.file.output-metadata":    "",
+		"streamers.file.prefix":             "",
+		"streamers.file.stop-node-on-error": "",
+		"streamers.file.write_dir":          "",
+
+		"telemetry.enable-hostname-label":     "",
+		"telemetry.enable-hostname":           "",
+		"telemetry.enable-service-label":      "",
+		"telemetry.enabled":                   "",
+		"telemetry.global-labels":             "",
+		"telemetry.prometheus-retention-time": "",
+		"telemetry.service-name":              "",
+	}
+	unknownFlagNames := []string{}
+	missingFlagNames := map[string]bool{}
+	for name := range expectedFlagNames {
+		missingFlagNames[name] = true
+	}
+	readFlag := func(name string) interface{} {
+		if defaultValue, found := expectedFlagNames[name]; found {
+			delete(missingFlagNames, name)
+			return defaultValue
+		}
+		unknownFlagNames = append(unknownFlagNames, name)
+		return nil
+	}
+
+	homeDir, err := os.MkdirTemp("", "cosmos-sdk-home")
+	if err != nil {
+		panic(err)
+	}
+	defer os.RemoveAll(homeDir)
+
+	// First get the command line flags that the base cosmos-sdk defines
+	dummyAppCreator := func(
+		logger log.Logger,
+		db dbm.DB,
+		traceStore io.Writer,
+		appOpts servertypes.AppOptions,
+	) servertypes.Application {
+		return new(app.GaiaApp)
+	}
+	cmd := server.StartCmd(dummyAppCreator, homeDir)
+	flags := cmd.Flags()
+	flags.SortFlags = true
+	flags.VisitAll(func(flag *pflag.Flag) {
+		readFlag(flag.Name)
+	})
+
+	// Then get the options parsing the default config file.
+	serverCtx := server.NewDefaultContext()
+	// appTemplate, appConfig := initAppConfig()
+	appTemplate := serverconfig.DefaultConfigTemplate
+	appConfig := serverconfig.DefaultConfig()
+	configTemplate := template.Must(template.New("").Parse(appTemplate))
+	var buffer bytes.Buffer
+	if err := configTemplate.Execute(&buffer, appConfig); err != nil {
+		panic(err)
+	}
+	serverCtx.Viper.SetConfigType("toml")
+	if err := serverCtx.Viper.MergeConfig(&buffer); err != nil {
+		panic(err)
+	}
+	for _, configKey := range serverCtx.Viper.AllKeys() {
+		readFlag(configKey)
+	}
+
+	if len(unknownFlagNames) != 0 {
+		t.Error(
+			"unknown CLI flags in cosmos-sdk; incorporate as needed and update this test",
+			unknownFlagNames,
+		)
+	}
+	if len(missingFlagNames) != 0 {
+		missing := []string{}
+		for name := range missingFlagNames {
+			missing = append(missing, name)
+		}
+		t.Error(
+			"expected CLI flags missing from cosmos-sdk; remove from this test",
+			missing,
+		)
+	}
+}