Skip to content

Commit

Permalink
run upgrade GC tests only under XS
Browse files Browse the repository at this point in the history
node/v8/ava is just too flaky, I was seeing #5575 -type problems in
test-upgrade.js
  • Loading branch information
warner committed Apr 5, 2023
1 parent 7ca461c commit 534dc31
Showing 1 changed file with 6 additions and 12 deletions.
18 changes: 6 additions & 12 deletions packages/SwingSet/test/upgrade/test-upgrade.js
Original file line number Diff line number Diff line change
Expand Up @@ -498,20 +498,14 @@ const testUpgrade = async (t, defaultManagerType, options = {}) => {
});
};

// run GC-sensitive upgrade tests that use a local worker serially
// to mitigate any V8 gremlins
test.serial('vat upgrade - local', async t => {
return testUpgrade(t, 'local', { restartVatAdmin: false });
});
test.serial('vat upgrade - local with VA restarts', async t => {
return testUpgrade(t, 'local', { restartVatAdmin: true });
});
test.serial('vat upgrade - local without automatic GC', async t => {
return testUpgrade(t, 'local', { suppressGC: true });
});
// local workers (under V8 and AVA) are notoriously flaky for GC
// behavior, even with test.serial, so run these tests only under XS

test('vat upgrade - xsnap', async t => {
return testUpgrade(t, 'xs-worker');
return testUpgrade(t, 'xs-worker', { restartVatAdmin: false });
});
test('vat upgrade - xsnap with VA restarts', async t => {
return testUpgrade(t, 'xs-worker', { restartVatAdmin: true });
});
test('vat upgrade - xsnap without automatic GC', async t => {
return testUpgrade(t, 'xs-worker', { suppressGC: true });
Expand Down

0 comments on commit 534dc31

Please sign in to comment.