fixup! fix(vaultFactory): don't prevent repayment based on DebtLimit

Agoric · Aug 16, 2024 · 5cc111c · 5cc111c
1 parent c35ab63
commit 5cc111c
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 7 deletions.
diff --git a/packages/inter-protocol/src/contractSupport.js b/packages/inter-protocol/src/contractSupport.js
@@ -67,8 +67,13 @@ export const allEmpty = amounts => {
  * @param {Amount<'nat'>} totalDebt
  * @param {Amount<'nat'>} toMint
  * @throws if minting would exceed total debt
+ *
+ *   Note: Succeeds regardless of debtLimit if toMint is empty.
  */
 export const checkDebtLimit = (debtLimit, totalDebt, toMint) => {
+  if (AmountMath.isEmpty(toMint)) {
+    return;
+  }
   const debtPost = AmountMath.add(totalDebt, toMint);
   AmountMath.isGTE(debtLimit, debtPost) ||
     Fail`Minting ${q(toMint)} past ${q(

diff --git a/packages/inter-protocol/src/vaultFactory/vaultManager.js b/packages/inter-protocol/src/vaultFactory/vaultManager.js
@@ -867,13 +867,11 @@ export const prepareVaultManagerKit = (
           const { state } = this;
           const { collateralBrand, totalDebt } = state;
 
-          if (!AmountMath.isEmpty(toMint)) {
-            checkDebtLimit(
-              factoryPowers.getGovernedParams(collateralBrand).getDebtLimit(),
-              totalDebt,
-              toMint,
-            );
-          }
+          checkDebtLimit(
+            factoryPowers.getGovernedParams(collateralBrand).getDebtLimit(),
+            totalDebt,
+            toMint,
+          );
           factoryPowers.mintAndTransfer(mintReceiver, toMint, fee, transfers);
         },
         /**

diff --git a/packages/inter-protocol/test/contractSupport.test.js b/packages/inter-protocol/test/contractSupport.test.js
@@ -20,3 +20,8 @@ test('checkDebtLimit allows at limit', t => {
 test('checkDebtLimit throws above', t => {
   t.throws(() => checkDebtLimit(limit, prior, debt.make(3n)));
 });
+
+test('checkDebtLimit always succeeds if there is nothing to mint', t => {
+  const bigPrior = debt.make(5n);
+  t.notThrows(() => checkDebtLimit(limit, bigPrior, debt.make(0n)));
+});