Skip to content

Commit

Permalink
docs: update references to addPool in documentation
Browse files Browse the repository at this point in the history
  • Loading branch information
Chris-Hibbert committed May 17, 2022
1 parent f9bd524 commit 5f704dc
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
8 changes: 4 additions & 4 deletions packages/run-protocol/src/vpool-xyk-amm/AttackersGuide.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,11 @@ liquidity providers to violate that expectation is a problem.
## Multiple Pools

`addPool` and `addLiquidity` are publicly available. That means someone could maliciously
create pools or provide insufficient liquidity. The ability to add liquidity in arbitrary
proportions should be enough to prevent misuse of these APIs from hurting us.
create pools or provide insufficient liquidity. The requirement of a minimum initial
liquidity should be enough to prevent misuse of these APIs from hurting us.

Since `addPool` is public, someone could add a look-alike issuer for a well-knownn
currency and make it harder for poepole to find the pool they intend to trade with. As
Since `addPool` is public, someone could add a look-alike issuer for a well-known
currency and make it harder for people to find the pool they intend to trade with. As
long as people are dealing wiht Brands and Issuers, they shouldn't be confused by
this. Does the Wallet UI provide enough clarity in the face of this?

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,8 @@ const { quote: q, details: X } = assert;
* terms. Separate invitations are available by calling methods on the
* publicFacet for adding and removing liquidity and for making trades. Other
* publicFacet operations support querying prices and the sizes of pools. New
* Pools can be created with addPool().
* Pools can be created by first calling addIssuer() and then exercising an
* invitation from addPoolInvitation().
*
* When making trades or requesting prices, the caller must specify either a
* maximum input amount (swapIn, getInputPrice) or a minimum output amount
Expand Down

0 comments on commit 5f704dc

Please sign in to comment.