Skip to content

Commit

Permalink
squash! tmp(governance): dubious error expectation change
Browse files Browse the repository at this point in the history
fix(governance): fix test result order
Add comment about possible rejections paths
  • Loading branch information
mhofman committed May 4, 2022
1 parent 6f2448f commit 6207d22
Showing 1 changed file with 8 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,14 @@ const expectedBrokenUpdateLog = [
'&& running a task scheduled for 2. &&',
'vote outcome: {"changes":{"Electorate":{"brand":"[Alleged: Zoe Invitation brand]","value":[{"description":"questionPoser","handle":"[Alleged: InvitationHandle]","installation":"[Alleged: Installation]","instance":"[Alleged: InstanceHandle]"}]},"MalleableNumber":"[42n]"}}',
'Validation complete: true',
// [`prepareToSetInvitation`](https://github.com/Agoric/agoric-sdk/blob/c6570b015fd23c411e48981bec309b32eedd3a28/packages/governance/src/contractGovernance/paramManager.js#L199-L212)
// does a `Promise.all` on 2 calls using the `invite` promise. If that promise
// is rejected, this will result in a rejection race between the 2 paths. The
// following 2 entries may come back as the commented out lines if the kernel
// changes the order in which messages are processed.
// TODO: allow either message
// 'vote rejected outcome: Error: (an object) was not a live payment for brand (an object). It could be a used-up payment, a payment for another brand, or it might not be a payment at all.',
// 'update failed: Error: (an object) was not a live payment for brand (an object). It could be a used-up payment, a payment for another brand, or it might not be a payment at all.',
'vote rejected outcome: Error: A Zoe invitation is required, not (an object)',
'update failed: Error: A Zoe invitation is required, not (an object)',
'current value of MalleableNumber is 602214090000000000000000',
Expand Down

0 comments on commit 6207d22

Please sign in to comment.