Skip to content

Commit

Permalink
Merge pull request #6029 from Agoric/6028-gc-not-defined
Browse files Browse the repository at this point in the history
fix(swingset): don't un-expose 'gc', to stop intermittent test failures
  • Loading branch information
mergify[bot] authored Aug 23, 2022
2 parents 45bc8a1 + c4f7038 commit 774d090
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions packages/SwingSet/src/lib-nodejs/engine-gc.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,13 @@ if (typeof bestGC !== 'function') {
// Node.js v8 wizardry.
v8.setFlagsFromString('--expose_gc');
bestGC = vm.runInNewContext('gc');
// Hide the gc global from new contexts/workers.
v8.setFlagsFromString('--no-expose_gc');
// We leave --expose_gc turned on, otherwise AVA's shared workers
// may race and disable it before we manage to extract the
// binding. This won't cause 'gc' to be visible to new Compartments
// because SES strips out everything it doesn't recognize.

// // Hide the gc global from new contexts/workers.
// v8.setFlagsFromString('--no-expose_gc');
}

// Export a const.
Expand Down

0 comments on commit 774d090

Please sign in to comment.