Skip to content

Commit

Permalink
fix: ConnectionHandler methods should return promises
Browse files Browse the repository at this point in the history
  • Loading branch information
0xpatrickdev committed Mar 25, 2024
1 parent 6d2d41b commit b1184b5
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions packages/orchestration/src/contracts/stakeAtom.contract.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,17 +34,17 @@ export const start = async (_zcf, privateArgs, baggage) => {
// const { makeRecorderKit } = prepareRecorderKitMakers(baggage, marshaller);

const connectionHandler = Far('ConnectionHandler', {
onOpen(connection, localAddr, remoteAddr) {
async onOpen(connection, localAddr, remoteAddr) {
// XXX this seems flipped? onOpen(connection, remoteAddr, localAddr)
trace('onOpen', JSON.stringify({ localAddr, remoteAddr }));
trace('onOpen connection', connection);
return '{"result":"AQ=="}';
// return '{"result":"AQ=="}';
},
onClose(_connection, reason) {
async onClose(_connection, reason) {
trace('onClose', reason);
// XXX what should the behavior be here?
},
onReceive(_connection, bytes) {
async onReceive(_connection, bytes) {
/// XXX maybe should throw an error since ica connections will not receive packets?
// the types want us to return something here
trace('onReceive', bytes);
Expand Down

0 comments on commit b1184b5

Please sign in to comment.