Skip to content

Commit

Permalink
chore(orchestration): document TODOs with ticket numbers
Browse files Browse the repository at this point in the history
  • Loading branch information
0xpatrickdev committed Jun 28, 2024
1 parent 0b08156 commit cb5f043
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 1 deletion.
2 changes: 2 additions & 0 deletions packages/orchestration/src/exos/chain-account-kit.js
Original file line number Diff line number Diff line change
Expand Up @@ -102,10 +102,12 @@ export const prepareChainAccountKit = (zone, { watch, asVow }) =>
);
},
getBalance(_denom) {
// TODO https://github.com/Agoric/agoric-sdk/issues/9610
// UNTIL https://github.com/Agoric/agoric-sdk/issues/9326
return asVow(() => Fail`not yet implemented`);
},
getBalances() {
// TODO https://github.com/Agoric/agoric-sdk/issues/9610
// UNTIL https://github.com/Agoric/agoric-sdk/issues/9326
return asVow(() => Fail`not yet implemented`);
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -374,6 +374,7 @@ export const prepareCosmosOrchestrationAccountKit = (
);
},
getBalances() {
// TODO https://github.com/Agoric/agoric-sdk/issues/9610
return asVow(() => Fail`not yet implemented`);
},
/**
Expand Down
2 changes: 2 additions & 0 deletions packages/orchestration/src/exos/local-chain-facade.js
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,10 @@ const prepareLocalChainFacadeKit = (
/** @returns {Vow<PromiseToVow<OrchestrationAccount<ChainInfo>>>} */
makeAccount() {
const lcaP = E(localchain).makeAccount();
// TODO #9449 fix types
// @ts-expect-error 'Vow<Guarded<{...}>> is not assignable to type 'Vow<never>'
return watch(
// TODO #9449 fix types
// @ts-expect-error Property 'getAddress' does not exist on type 'EMethods<Required<Guarded<{ getAddress()...
allVows([lcaP, E(lcaP).getAddress()]),
this.facets.makeAccountWatcher,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -304,6 +304,7 @@ export const prepareLocalOrchestrationAccountKit = (
);
},
getBalances() {
// TODO https://github.com/Agoric/agoric-sdk/issues/9610
return asVow(() => Fail`not yet implemented`);
},

Expand Down
2 changes: 2 additions & 0 deletions packages/orchestration/src/exos/orchestrator.js
Original file line number Diff line number Diff line change
Expand Up @@ -115,12 +115,14 @@ export const prepareOrchestratorKit = (
/** @type {PromiseToVow<Orchestrator['getChain']>} */
getChain(name) {
if (name === 'agoric') {
// TODO #9449 fix types
// @ts-expect-error Type 'Vow<Voidless>' is not assignable to type 'Vow<Chain<any>>'.
return watch(
chainHub.getChainInfo('agoric'),
this.facets.makeLocalChainFacadeWatcher,
);
}
// TODO #9449 fix types
// @ts-expect-error Type 'Vow<Voidless>' is not assignable to type 'Vow<Chain<any>>'.
return watch(
chainHub.getChainsAndConnection('agoric', name),
Expand Down
3 changes: 2 additions & 1 deletion packages/orchestration/src/exos/remote-chain-facade.js
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,8 @@ const prepareRemoteChainFacadeKit = (

/** @returns {Vow<PromiseToVow<OrchestrationAccount<ChainInfo>>>} */
makeAccount() {
// @ts-expect-error 'Vow<Guarded<{...}>> is not assignable to type 'Vow<never>'
// TODO #9449 fix types
// @ts-expect-error 'Vow<Guarded<{...}>> is not assignable to type 'Vow<never>' #9449
return asVow(() => {
const { remoteChainInfo, connectionInfo } = this.state;
const stakingDenom = remoteChainInfo.stakingTokens?.[0]?.denom;
Expand Down

0 comments on commit cb5f043

Please sign in to comment.