refactor(smart-wallet): re-use MapStore for has/get/values

After changing [...values()] to just values(), I went to find
consumers who would now need to construct the array, but it
looks like registry.values() is no longer used.

While looking, I discovered that the return type of
t.context.simpleProvideWallet() defaulted to any.

packages/smart-wallet/src/smartWallet.js

@@ -95,13 +95,10 @@ const mapToRecord = map => Object.fromEntries(map.entries());
  *   walletStorageNode: StorageNode,
  * }} UniqueParams
  *
+ * @typedef {Pick<MapStore<Brand, BrandDescriptor>, 'has' | 'get' | 'values'>} ReadOnlyMapStore
  * @typedef {{
  *   agoricNames: ERef<import('@agoric/vats').NameHub>,
- *   registry: {
- *     has: (b: Brand) => boolean,
- *     get: (b: Brand) => BrandDescriptor,
- *     values: () => BrandDescriptor[],
- *   },
+ *   registry: ReadOnlyMapStore,
  *   invitationIssuer: Issuer<'set'>,
  *   invitationBrand: Brand<'set'>,
  *   invitationDisplayInfo: DisplayInfo,
@@ -144,7 +141,7 @@ export const prepareSmartWallet = (baggage, shared) => {
       invitationDisplayInfo: DisplayInfoShape,
       publicMarshaller: M.remotable('Marshaller'),
       zoe: M.eref(M.remotable('ZoeService')),
-      registry: M.remotable('AssetRegistry'),
+      registry: M.remotable('AssetRegistry'), // XXX too strict
     }),
   );
 

packages/smart-wallet/src/walletFactory.js

@@ -99,7 +99,7 @@ const makeAssetRegistry = assetPublisher => {
     has: brand => brandDescriptors.has(brand),
     /** @param {Brand} brand */
     get: brand => brandDescriptors.get(brand),
-    values: () => [...brandDescriptors.values()],
+    values: () => brandDescriptors.values(),
   });
   return registry;
 };

packages/smart-wallet/test/contexts.js

@@ -55,6 +55,7 @@ export const makeDefaultTestContext = async (t, makeSpace) => {
     // copied from makeClientBanks()
     const bank = E(consume.bankManager).getBankForAddress(address);
 
+    /** @type {[ReturnType<ReturnType<import('../src/smartWallet').prepareSmartWallet>>, boolean]} */
     const [wallet, _isNew] = await E(
       walletFactory.creatorFacet,
     ).provideSmartWallet(address, bank, consume.namesByAddressAdmin);