Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposer can use CosGov to propose new committee via core eval (install bundle, upload files) #10138

Closed
otoole-brendan opened this issue Sep 24, 2024 · 6 comments · Fixed by #10241
Assignees
Labels
Governance Governance

Comments

@otoole-brendan
Copy link
Contributor

otoole-brendan commented Sep 24, 2024

What is the Problem Being Solved?

To rotate the EC membership, someone needs to be able to submit a proposal to do so.

Description of the Design

A builder script to go with gov-replace-committee.js (as revised along the lines of #10105) such that agoric run new-builder-script.js produces the relevant artifacts.

Security Considerations

Scaling Considerations

Test Plan

Should be covered by a3p-integration tests in #10136, #10137 . But those are P2, so if we choose not to do them, let's be sure to test that here.

Upgrade Considerations

@aj-agoric
Copy link

Per meeting 9/24 this ticket is to create the input files to be used in the cosgov/agoric proposal builder

@dckc
Copy link
Member

dckc commented Sep 24, 2024

test plan should include

  • estimate the cost of installing the bundles

@frazarshad frazarshad self-assigned this Sep 25, 2024
@dckc dckc added the Governance Governance label Sep 27, 2024
@dckc
Copy link
Member

dckc commented Sep 27, 2024

@otoole-brendan I suggest moving "can use CosGov to " out of the title to the design. It's sort of misleading - it looks like we're making a change to CosGov.

@dckc
Copy link
Member

dckc commented Oct 8, 2024

as noted in #10164 (comment) , there's a little work to do here

mergify bot added a commit that referenced this issue Oct 8, 2024
closes: #10134
refs: #10134

## Description
This PR implements the following:

- Core eval script to replace the committee.
- Builder script for setting up the core eval.
- Bootstrap test to verify the functionality of the implementation.

### Security Considerations
The Economic Committee plays a crucial role in managing the Inter-Protocol. The current committee doesn't easily support a smooth transition when members must retire or be replaced. An incomplete transition to a new committee could severely hamper the chain operations.

Accidentally providing access to the wrong parties (or failing to remove parties whose terms have expired) could make it hard to ensure that the right committee members have control. Other chains have been sunk or badly damaged when the stakeholders couldn't restrict some people from making changes.

### Testing Considerations
Bootstrap tests have been added in this PR to run in CI for testing.

### Documentation Considerations
Specific documentation concerns belong in #10138. It’s important to ensure the proposal is clearly documented to avoid confusion, especially with the old committee still being around.

### Upgrade Considerations:
There is minimal risk of regression because the core-eval materials are introduced in new files. The changes introduced particularly the new builder script, can be seamlessly included in any upcoming release.

### Scaling Considerations
The core eval script’s performance depends on the number of Economic Committee (EC) members. Since the committee is limited to a maximum of 12 members, the script’s complexity is treated as constant because it won’t have to handle more than 12 people.

Also, the script is executed approximately once a year, and all stakers receive a 3-day notice before it runs, making the scaling impact negligible.
@dckc
Copy link
Member

dckc commented Oct 15, 2024

@otoole-brendan @frazarshad I think this is now obsolete in favor of...

@dckc
Copy link
Member

dckc commented Oct 24, 2024

obsolete in favor of #10258

@dckc dckc closed this as not planned Won't fix, can't repro, duplicate, stale Oct 24, 2024
@mergify mergify bot closed this as completed in #10241 Oct 24, 2024
mergify bot added a commit that referenced this issue Oct 24, 2024
closes: #10138 
closes: #10185 
closes: #10258
## Description

A3P tests for the replace electorate core eval. also adds the replace-electorate-core.js script to upgrade.go since it will now be a part of the chain halting upgrade

new tests are as follows:
- adds new `n:replace-electorate` which tests for acceptance of new invitations
- adds params governance proposal and voting tests to `z:acceptance`

### Security Considerations


### Scaling Considerations


### Documentation Considerations


### Testing Considerations


### Upgrade Considerations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Governance Governance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants