Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove “BLD” and “RUN” keys from run-protocol code #4800

Closed
Tartuffo opened this issue Mar 9, 2022 · 4 comments · Fixed by #5585
Closed

Remove “BLD” and “RUN” keys from run-protocol code #4800

Tartuffo opened this issue Mar 9, 2022 · 4 comments · Fixed by #5585
Assignees
Labels
AMM audit-restival Purple Team review of RUN Protocol Inter-protocol Overarching Inter Protocol technical-debt Vaults VaultFactor (née Treasury)
Milestone

Comments

@Tartuffo
Copy link
Contributor

Tartuffo commented Mar 9, 2022

RUN/IST role cases

vaultFactory

Token that is minted, secured by collateral (per vault manager)
keyword: Minted
Proposal shape will be {give: Collateral, want: Debt}

runStake / bldBoost

Token that is minted, secured by collateral.
keyword: 'Minted'

feeDistributor

Fee.
keyword: Fee
The CollectFees offer result will by a seat with getPayout('Fee').

assetReserve

Fee mint to hold penalties
keyword: Fee

psm

Stable
keyword: Stable (already)

@Tartuffo Tartuffo added audit-restival Purple Team review of RUN Protocol Inter-protocol Overarching Inter Protocol labels Mar 9, 2022
@dtribble
Copy link
Member

dtribble commented Mar 9, 2022

This includes removing it as the keyword for the stable token in

  const runMint = await zcf.registerFeeMint('RUN', privateArgs.feeMintAccess);

@dckc
Copy link
Member

dckc commented Jun 1, 2022

@turadg to propose role-based keywords

@Chris-Hibbert
Copy link
Contributor

I'd pretty strongly prefer 'loan' to 'debt' for the vault factory. It's only 'debt' on one side of the balance sheet. Similarly with bldBoost.

@Chris-Hibbert
Copy link
Contributor

'collateral' doesn't seem ideal for BLD. There are lots of assets that are collateral. BLD is uniquely the one that represents equity in the chain. Maybe 'Stake' would work.

@turadg turadg linked a pull request Jun 13, 2022 that will close this issue
18 tasks
@turadg turadg changed the title Remove “BLD” and “RUN” from run-protocol code Remove “BLD” and “RUN” keys from run-protocol code Jun 14, 2022
@mergify mergify bot closed this as completed in #5585 Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AMM audit-restival Purple Team review of RUN Protocol Inter-protocol Overarching Inter Protocol technical-debt Vaults VaultFactor (née Treasury)
Projects
None yet
5 participants