4800 rename run-protocol package to inter-protocol #5595
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. ([^\w])RUN --> $1Minted 2. manual fixes
turadg
changed the title
packages/cosmic-swingset/Makefile
Outdated
| @@ -49,7 +49,7 @@ $(EVAL_CLEAN): $(EVAL_CODE) | |||
| ./scripts/clean-core-eval.js $< >$@.t || { rm -f $@.t; exit 1; } | |||
| mv $@.t $@ | |||
|
|
|||
| RUN_PROTO=../run-protocol | |||
| RUN_PROTO=../inter-protocol | |||
There was a problem hiding this comment.
Why leave RUN_PROTO behind?
There was a problem hiding this comment.
not intentional. this was a find-replace and I haven't looked over all the instances yet. I figured I would keep putting commits into #5585 but I'll get more into this one and mark it as Draft until I think it's ready to merge.
packages/cosmic-swingset/Makefile
Outdated
| @@ -71,8 +71,8 @@ gov-q: | |||
| $(AGCH) query gov proposals --output json | \ | |||
| jq -c '.proposals[] | [.proposal_id,.voting_end_time,.status]' | |||
|
|
|||
| deploy-runStake: ../run-protocol/test/runStake/runStake-deploy.js | |||
| echo agoric deploy ../run-protocol/test/runStake/runStake-deploy.js | |||
| deploy-runStake: ../inter-protocol/test/runStake/runStake-deploy.js | |||
There was a problem hiding this comment.
Is runStake renaming a separate pass?
There was a problem hiding this comment.
yep, needed to get alignment on the new name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of: #4800
Description
Single commit for review to include in the mega #5585
Security Considerations
no change
Documentation Considerations
Do we need a package redirect notice? I figure SDK is understood to be in flux, and the
agoriccommand works as well.Testing Considerations
--