Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need dependable mechanism for getting Vault issuers into your wallet #4819

Open
Tartuffo opened this issue Mar 10, 2022 · 7 comments
Open

Need dependable mechanism for getting Vault issuers into your wallet #4819

Tartuffo opened this issue Mar 10, 2022 · 7 comments
Assignees
Labels
audit-restival Purple Team review of RUN Protocol Inter-protocol Overarching Inter Protocol namehub-petname issuer naming, petnames, namehubs, ... needs-design wallet

Comments

@Tartuffo
Copy link
Contributor

A pet naming the wallet maintains and imports into the DApps.

One namespace shared across all user interfaces. Also needs to work for Pegasus imports.

@Tartuffo Tartuffo added audit-restival Purple Team review of RUN Protocol Inter-protocol Overarching Inter Protocol wallet labels Mar 10, 2022
@michaelfig
Copy link
Member

We intend to use ibc-go's transfer module (running on the transfer port) to send tokens to the Agoric chain. Then, we will "bless" the relevant denom (ibc/xxx) to correspond to a bank purse, so that every wallet automatically gets an ERTP purse for the asset, pegged to their Cosmos ibc/xxx token balance.

@Tartuffo
Copy link
Contributor Author

Currently, the Vault UI suggests issuers and what to call them, which are stored in the wallet.
Wallet Bridge is where DAPP communicates with user Wallet, Wallet has objects -> paths.
Needs to be a pet name path, in the Agoric supported naming hub. So user's pet name for the naming hub, + the path in the naming hub.
The Vault is the pet name, Vault.ATOM would be the path for ATOM.
Governance should install a naming hub.
The missing piece is to be able to say "sign me up for (the chain's gov-approved) standard names, or Joe's standard names)
one question is whether we show the path explicitly in the UI, or make that available via mouse-over.

@Tartuffo Tartuffo added this to the Mainnet 1 milestone Mar 23, 2022
@michaelfig
Copy link
Member

If the assets already need to be exposed by the bank vat (like IBC transfer assets), we have an automatic solution. This ticket is for assets that aren't part of the bank.

@Tartuffo Tartuffo removed this from the Mainnet 1 milestone Mar 24, 2022
@dckc
Copy link
Member

dckc commented Apr 11, 2022

I talked about this with @michaelfig .

The VBANK currently provides a solution in this space that seems adequate for some near-term scenarios: issuers for assets added to the VBANK get into wallets of all users. The ATOM issuer used for vaults will be created via VBANK.

It doesn't accomodate Pegasus, decentralized lists, etc.

@Tartuffo
Copy link
Contributor Author

This issue is about getting a denom into the purse.

  1. I have to know the name of the denom up front. You need the IBC path (a hash).
  2. Write about 30 lines of code, submit to Gov vote, and execute the 30 lines on the vote passing.

Making this less centralized is not needed for MN-1.

@dckc
Copy link
Member

dckc commented Apr 13, 2022

@dtribble and @michaelfig refined the design above:

@dckc
Copy link
Member

dckc commented Nov 8, 2022

I suppose this recent problem report means this issue came up in production:

it would be nice if

  • our wallet followed the convention of defaulting to the cosmos chain registry for IBC asset naming.
  • users could also add unregistered tokens or rename registered tokens

As to solutions, at one point we planned to do these two; that plan still makes sense to me:

Supporting the chain registry would be another work item. Getting the data from github on chain would need something like oracle price submission. I suppose it's possible for the wallet UI to query github rather than the chain, but that mixes trust models in a weird way.

Supporting user-configured names -- basically petnames -- would be another item.

cc @otoole-brendan @michaelfig @ivanlei @erights

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audit-restival Purple Team review of RUN Protocol Inter-protocol Overarching Inter Protocol namehub-petname issuer naming, petnames, namehubs, ... needs-design wallet
Projects
None yet
Development

No branches or pull requests

5 participants