Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose VBANK brand list via chainStorage RPC #5762

Closed
Tracked by #6652
dckc opened this issue Jul 13, 2022 · 4 comments · Fixed by #6700
Closed
Tracked by #6652

expose VBANK brand list via chainStorage RPC #5762

dckc opened this issue Jul 13, 2022 · 4 comments · Fixed by #6700
Assignees
Labels
enhancement New feature or request Inter-protocol Overarching Inter Protocol read-no-tx topic: reading from the chain without a transaction wallet

Comments

@dckc
Copy link
Member

dckc commented Jul 13, 2022

What is the Problem Being Solved?

The VBANK provides a subscription for new assets that includes a keyword/symbol and string name, but:

Description of the Design

pretty much implicit in the above

agoricNames should also be exposed via chainStorage RPC; it might be easier to roll that into this issue.

Security Considerations

Getting new assets into the VBANK is a privileged operation, currently reserved to the BLDer DAO. For a more decentralized approach, see wallet issues such as #5107.

Test Plan

unit tests for the items in the Description above

Demonstrate in econ testing: #5681

@dckc dckc added enhancement New feature or request wallet Inter-protocol Overarching Inter Protocol read-no-tx topic: reading from the chain without a transaction labels Jul 13, 2022
@dckc dckc self-assigned this Jul 13, 2022
@dckc
Copy link
Member Author

dckc commented Jul 22, 2022

This might not be needed. @samsiegart and I just figured out a small tweak to the AMM contract:

  • include the displayInfo (incl. decimalPlaces) in :published.amm.metrics.

If we make sure RPC chainStorage from each contract does this for its brands, we could perhaps do without it from VBANK.

We would lose the VBANK's string name (proposedName).

@dckc
Copy link
Member Author

dckc commented Aug 29, 2022

on further review, I can't figure out why this is necessary for #6021

@dckc dckc removed the pso label Aug 29, 2022
@Tartuffo Tartuffo removed this from the Mainnet 1 RC0 milestone Sep 21, 2022
@dckc
Copy link
Member Author

dckc commented Oct 21, 2022

brainstormed with @erights @michaelfig and @warner today... I think this is important for medium term work, though I don't suppose we came up with any hard requirement for it.

@dckc
Copy link
Member Author

dckc commented Nov 8, 2022

Motivation: currently the only way to find the vbank's name for a brand is to look it up via some user's wallet. What if you don't have a wallet address? You're just doing some chain-wide dashboard?

Well, I suppose you can pick one arbitrarily, but that sure seems awkward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Inter-protocol Overarching Inter Protocol read-no-tx topic: reading from the chain without a transaction wallet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants