-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expose VBANK brand list via chainStorage RPC #5762
Comments
This might not be needed. @samsiegart and I just figured out a small tweak to the AMM contract:
If we make sure RPC chainStorage from each contract does this for its brands, we could perhaps do without it from VBANK. We would lose the VBANK's string name ( |
on further review, I can't figure out why this is necessary for #6021 |
brainstormed with @erights @michaelfig and @warner today... I think this is important for medium term work, though I don't suppose we came up with any hard requirement for it. |
Motivation: currently the only way to find the vbank's name for a brand is to look it up via some user's wallet. What if you don't have a wallet address? You're just doing some chain-wide dashboard? Well, I suppose you can pick one arbitrarily, but that sure seems awkward. |
What is the Problem Being Solved?
The VBANK provides a subscription for new assets that includes a keyword/symbol and string name, but:
Description of the Design
pretty much implicit in the above
agoricNames
should also be exposed via chainStorage RPC; it might be easier to roll that into this issue.Security Considerations
Getting new assets into the VBANK is a privileged operation, currently reserved to the BLDer DAO. For a more decentralized approach, see wallet issues such as #5107.
Test Plan
unit tests for the items in the Description above
Demonstrate in econ testing: #5681
The text was updated successfully, but these errors were encountered: