add liquidity to an existing pool (with smart wallet)

[rowgraus]

As a new liquidity provider, I need to be able to add liquidity to an existing pool

• I must add liquidity in the existing ratio of assets the pool
• I would like quick action buttons that will add maximum liquidity based on my asset balances (note: UX issue - asset balances may span multiple purses)
• I would like “single asset liquidity provision” which lets me pick one asset to provide, and the front end then trades half into the other asset and adds the result as liquidity (nice-to-have; not blocking)
• use background signer (delegate from interactive signer to background signer for low-privilege actions #4406) when adding the liquidity issuer?

[samsiegart]

I believe this is implemented, but not the single asset part

[samsiegart]

@rowgraus Can we break out the single-asset-liquidity feature into a separate ticket?

[dckc]

I can't get this to work on devnet. The UI spins after I choose IbcATOM.

I thought maybe it was because there is no liquidity yet, but I can't get adding liquidity to work from the REPL either.
log of my attempts: https://gist.github.com/dckc/4415d09a33d257267f2825ab967e7b06

@Chris-Hibbert @arirubinstein @mhofman can you tell what I'm doing wrong?

[dckc]

@arirubinstein pointed me at amm_swap.js; I had no luck with that either.

I basically just substituted IbcATOM for BLD:
https://gist.github.com/dckc/4415d09a33d257267f2825ab967e7b06#file-amm_swap-js

$ agoric deploy scripts/amm_swap.js 
Open CapTP connection to ws://127.0.0.1:8000/private/captp...o
agoric: deploy: running /home/connolly/projects/agoric/agoric-sdk/packages/run-protocol/scripts/amm_swap.js
agoric: deploy: Deploy script will run with Node.js ESM
awaiting home promise...
swap
add liquidity
CapTP bundle exception: (RemoteRangeError(error:captp:unknown#20001)#1)
RemoteRangeError(error:captp:unknown#20001)#1: floorDivide: zero divider

  at WebSocket.<anonymous> (packages/agoric-cli/src/deploy.js:120:13)
  at WebSocket.emit (node:events:520:28)
...

[dckc]

AUSD pool works

The IbcATOM pool is in some strange state. So with @Chris-Hibbert , I made a new pool using the "Anchor" asset, AUSD (aka USDC) and all seems well:

[dckc]

We're talking about this as a stretch goal for an upcoming release.

[dckc]

@rowgraus , our current approach to adding a the liquidity issuer (#5914) involves an interactive signature (using keplr). We aim to take advantage of the background signer (#4406) in due course; I'm interested on your take on how important that is for this launch story. I suppose you'll ask for an estimate, so we better look into it, @samsiegart .

[dckc]

@nalinbhatt was able to add liquidity. rough edges:

• "why do I have to choose that pool thing?"
• "add issuer" issue was unresponsive (clue/work-around: reload wallet, dapp)

[dckc]

I think changes to the smart wallet API mean this doesn't quite work any more.

[turadg]

I think this is no longer planned. If it is, @otoole-brendan please reopen and revise the description with what's left to do.

[otoole-brendan]

Agreed