Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove my liquidity from an AMM pool #5080

Closed
3 tasks done
rowgraus opened this issue Apr 11, 2022 · 6 comments
Closed
3 tasks done

remove my liquidity from an AMM pool #5080

rowgraus opened this issue Apr 11, 2022 · 6 comments
Assignees
@samsiegart
Labels
AMM Inter-protocol Overarching Inter Protocol user-story User story that needs to be implemented and tested.

Comments

@rowgraus
Copy link

rowgraus commented Apr 11, 2022 •
edited by dckc
Loading

As an existing liquidity provider, I need to be able to

  • remove my liquidity from a pool
    • Quick action buttons or a slider based on percentage of liquidity (i.e., up to 100%)
    • I am shown a projected amount of each token returned after the transaction
@rowgraus rowgraus added the user-story User story that needs to be implemented and tested. label Apr 11, 2022
@Tartuffo Tartuffo added the Inter-protocol Overarching Inter Protocol label Apr 11, 2022
@Tartuffo Tartuffo added this to the Mainnet 1 milestone Apr 12, 2022
@samsiegart
Copy link
Contributor

We have this but the buttons only go up to 75%, need to add 100% button

@samsiegart
Copy link
Contributor

Added 100% button

@dckc dckc changed the title As an existing liquidity provider, I need to be able to remove my liquidity from a pool remove my liquidity from an AMM pool May 6, 2022
@dckc dckc added the AMM label May 6, 2022
@dckc
Copy link
Member

dckc commented May 6, 2022

@samsiegart I can't see any reason why you didn't close this.

@dckc dckc closed this as completed May 6, 2022
@Tartuffo Tartuffo reopened this Aug 10, 2022
@Tartuffo Tartuffo assigned samsiegart and unassigned rowgraus and samsiegart Aug 10, 2022
@Tartuffo Tartuffo removed this from the Mainnet 1 RC0 milestone Aug 15, 2022
@dckc
Copy link
Member

dckc commented Aug 18, 2022

@samsiegart reports getting this to work with the smart wallet, along with adding (#5077), so let's include it in this round of e2e testing.

@dckc
Copy link
Member

dckc commented Aug 18, 2022

@nalinbhatt was able to remove liquidity.

rough edges:

  • only the "add" button showed up, not "remove" (took screenshot)
    • work-around: reload the dApp

@dckc dckc closed this as completed Aug 18, 2022
@dckc
Copy link
Member

dckc commented Nov 1, 2022

I think changes to the smart wallet API mean this doesn't quite work any more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samsiegart samsiegart

Labels
AMM Inter-protocol Overarching Inter Protocol user-story User story that needs to be implemented and tested.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dckc @Tartuffo @samsiegart @rowgraus