Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

anInstanceStorageManager.deleteInstanceAdmin guarded wrong, so likely doesn't work #8341

Closed
erights opened this issue Sep 16, 2023 · 1 comment
Closed

anInstanceStorageManager.deleteInstanceAdmin guarded wrong, so likely doesn't work #8341

erights opened this issue Sep 16, 2023 · 1 comment
Assignees
@Chris-Hibbert

Comments

@erights
Copy link
Member

erights commented Sep 16, 2023

agoric-sdk/packages/zoe/src/typeGuards.js

Line 227 in 97cb715

deleteInstanceAdmin: M.call(InstanceAdminI).returns(),

Should be

deleteInstanceAdmin: M.call(InstanceAdminShape).returns(),

Caught by the stricter checking of endojs/endo#1712 as tested by #8340

See #8339 (review)
@erights erights mentioned this issue Sep 16, 2023
Merged
@erights
Copy link
Member Author

erights commented Sep 18, 2023

Fixed by #8339

@erights erights closed this as completed Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Chris-Hibbert Chris-Hibbert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@erights @Chris-Hibbert