Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(patterns)!: tag and retype guards #1712

Merged
merged 2 commits into from
Sep 18, 2023
Merged

fix(patterns)!: tag and retype guards #1712

merged 2 commits into from
Sep 18, 2023

Conversation

erights
Copy link
Contributor

@erights erights commented Aug 8, 2023 •
edited
Loading

Staged on #1771

Make guards a distinct category of taggeds, on par with matchers.

@erights erights self-assigned this Aug 8, 2023
@erights erights force-pushed the markm-tag-guards-2 branch from 6a02ab0 to 6878f17 Compare August 8, 2023 01:59
This was referenced Aug 8, 2023
Closed
Merged
@erights erights force-pushed the markm-tag-guards-2 branch from 6878f17 to 1e25987 Compare August 9, 2023 02:20
@erights erights changed the base branch from master to markm-type-guards August 9, 2023 02:20
@erights erights force-pushed the markm-tag-guards-2 branch 2 times, most recently from b05871a to 2a13b3d Compare August 9, 2023 02:27
@erights erights changed the title WIP fix(patterns)!: tag and type guards WIP fix(patterns)!: tag and retype guards Aug 9, 2023
@erights erights force-pushed the markm-type-guards branch from a0170df to 505f81f Compare August 15, 2023 22:53
@erights erights force-pushed the markm-tag-guards-2 branch from 2a13b3d to 1cbe96d Compare August 15, 2023 23:01
@erights erights mentioned this pull request Aug 16, 2023
Closed
michaelfig
michaelfig reviewed Aug 16, 2023
View reviewed changes
Copy link
Member

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

packages/patterns/src/types.js Show resolved Hide resolved
@erights erights mentioned this pull request Aug 18, 2023
Merged
@erights erights force-pushed the markm-type-guards branch from 505f81f to c2cd034 Compare August 21, 2023 22:48
Base automatically changed from markm-type-guards to master August 21, 2023 22:58
@erights erights force-pushed the markm-tag-guards-2 branch from 1cbe96d to 81cae91 Compare August 21, 2023 23:26
@erights erights mentioned this pull request Aug 28, 2023
Merged
@erights erights force-pushed the markm-tag-guards-2 branch from 81cae91 to 3f9eda8 Compare August 28, 2023 04:18
@erights erights changed the base branch from master to markm-abstract-guard-tag August 28, 2023 04:18
@erights
Copy link
Contributor Author

erights commented Aug 28, 2023

Reviewers,
This is actually ready for review, but not marked as such because it cannot be merged until agoric-sdk uses #1745 to be compat with the transition to this PR.

@erights erights force-pushed the markm-abstract-guard-tag branch from 0e642c3 to 14b381a Compare August 28, 2023 05:09
@erights erights force-pushed the markm-tag-guards-2 branch from 3f9eda8 to b13aa5b Compare August 28, 2023 05:10
@erights erights requested a review from michaelfig August 28, 2023 06:44
@erights erights force-pushed the markm-abstract-guard-tag branch from 14b381a to 4eb0bd1 Compare August 29, 2023 05:00
@erights erights force-pushed the markm-tag-guards-2 branch from b13aa5b to 441a75d Compare August 29, 2023 05:03
@erights erights force-pushed the markm-abstract-guard-tag branch 2 times, most recently from 4e66d97 to ca66ee9 Compare August 30, 2023 01:18
@erights erights force-pushed the markm-tag-guards-2 branch from 441a75d to 15b4ec9 Compare August 30, 2023 01:20
@erights erights force-pushed the markm-abstract-guard-tag branch from ca66ee9 to dcf1071 Compare August 31, 2023 00:15
Base automatically changed from markm-abstract-guard-tag to master August 31, 2023 00:23
@erights erights force-pushed the markm-tag-guards-2 branch 2 times, most recently from bb265ae to 4650264 Compare September 13, 2023 03:58
This was referenced Sep 16, 2023
Merged
Merged
@erights
Copy link
Contributor Author

erights commented Sep 16, 2023

Agoric/agoric-sdk#8339 is where we're altering agoric-sdk to pave the way for this PR.

@erights erights changed the base branch from master to markm-interface-guard-type-param September 16, 2023 02:42
This was referenced Sep 16, 2023
Closed
Closed
Base automatically changed from markm-interface-guard-type-param to master September 16, 2023 19:14
@erights erights marked this pull request as ready for review September 16, 2023 23:57
@erights
Copy link
Contributor Author

erights commented Sep 16, 2023

Hi @michaelfig , with Agoric/agoric-sdk#8339 merged, this is now ready for review.

@erights
Copy link
Contributor Author

erights commented Sep 17, 2023

Hi @michaelfig , with Agoric/agoric-sdk#8339 merged, this is now ready for review.

And with Agoric/agoric-sdk#8340 showing that agoric-sdk should now be compat with this PR

@erights erights changed the title WIP fix(patterns)!: tag and retype guards fix(patterns)!: tag and retype guards Sep 17, 2023
michaelfig
michaelfig approved these changes Sep 17, 2023
View reviewed changes
Copy link
Member

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval on the condition that you clearly decide whether to parameterize CopyTagged, or to leave that out of this PR.

packages/patterns/src/types.js Outdated Show resolved Hide resolved
@erights erights force-pushed the markm-tag-guards-2 branch 3 times, most recently from acb5a1c to 7cf5027 Compare September 18, 2023 04:59
@erights erights merged commit 25c44ba into master Sep 18, 2023
14 checks passed
@erights erights deleted the markm-tag-guards-2 branch September 18, 2023 05:31
@erights erights mentioned this pull request Oct 14, 2023
Merged
This was referenced Feb 7, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelfig michaelfig michaelfig approved these changes

Assignees

@erights erights

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erights @michaelfig