Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The external dependency upon vstorage data format is not captured in unit tests #8615

Open
gibson042 opened this issue Dec 5, 2023 · 0 comments
Labels
enhancement New feature or request triaged_2024

Comments

@gibson042
Copy link
Member

@agoric/casting interacts directly with the vstorage KVStore using the /store/{storeName}/key cosmos-sdk escape hatch, making assumptions about the structure of keys and the structure of values. This creates an inherent constraint on our ability to change such details in vstorage, and that constraint should be captured in unit tests referencing the casting code (similar to what we did in #8538). Likewise, the casting code should reference documentation of the format rather than exercising in opaque deconstruction.

@gibson042 gibson042 added the enhancement New feature or request label Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triaged_2024
Projects
None yet
Development

No branches or pull requests

2 participants