fix(cli): handle not found error in vstorage requests #8538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsiegart
approved these changes
Nov 16, 2023
packages/agoric-cli/src/lib/rpc.js
Outdated
| @@ -143,7 +147,11 @@ export const makeVStorage = (powers, config = networkConfig) => { | |||
| )); | |||
| // console.debug('readAt returned', { blockHeight }); | |||
| } catch (err) { | |||
| if (err.message.match(/unknown request/)) { | |||
| if ( | |||
| err.message.match(/unknown request/) || | |||
There was a problem hiding this comment.
Any reason to keep this check around or can we remove it?
There was a problem hiding this comment.
to not break mainnet and devnet users, until each is respectively updated.
There was a problem hiding this comment.
Ah I just tested on devnet, I'm getting error code "6", so looks like the code changed and not just the message
There was a problem hiding this comment.
gibson042
approved these changes
Nov 16, 2023
|
@gibson042 I added a test suite to vstorage querier. PTAL |
gibson042
approved these changes
Nov 17, 2023
| path: []string{"data", "bar"}, | ||
| // DO NOT CHANGE | ||
| // The UI and CLI check for the specific cosmos-sdk error code & codespace | ||
| err: sdkerrors.ErrNotFound, |
There was a problem hiding this comment.
Would it be going too far to also assert somewhere that sdkerrors.ErrNotFound itself corresponds with code 38 in codespace "sdk"? That would capture our requirement of stability in cosmos-sdk.
mhofman
force-pushed
the
mhofman/8535-fix-cli-vstorage-not-found
branch
from
2e97211 to
21db80e
Compare
dckc
reviewed
Nov 17, 2023
mhofman
pushed a commit
that referenced
this pull request
Dec 6, 2023
…t-found fix(cli): handle not found error in vstorage requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #8535
refs: #8348
Description
#8348 changed the validation of vstorage paths, including the errors returned for invalid or not found paths.
Unfortunately some code had hardcoded part of the error message when iterating over values to break out of the iteration, resulting in the error terminating abruptly instead.
This change uses the more stable error code of the error returned by the RPC server.
Security Considerations
None
Scaling Considerations
None
Documentation Considerations
None
Testing Considerations
No integration test exists for this. I'm not sure where it could live.
Tested manually.
Upgrade Considerations
Should be backported to the
release-mainnet1Bfor consistency