Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incompatible with Node 20 #8636

Closed
turadg opened this issue Dec 8, 2023 · 2 comments
Closed

incompatible with Node 20 #8636

turadg opened this issue Dec 8, 2023 · 2 comments
Assignees
Labels
bug Something isn't working devex developer experience technical-debt triaged_2024

Comments

@turadg
Copy link
Member

turadg commented Dec 8, 2023

Describe the bug

Several packages depend on Bufferfile, which is incompatible with Node 20

Platform Environment

  • Node 20 in GH CI

Additional context

When fixing this, update code points for all mentions of this issue. Also update the package.json engines to include 20. Might be as simple as reverting: build: defer Node 20 compatibility

@dckc
Copy link
Member

dckc commented Jan 29, 2024

We can’t use Node 20 and anyone using the Active LTS can’t use Agoric SDK.

  • 11 Dec: @Chris-Hibbert reported complaints from yarn about node versions; @ivanlei noted this issue.
  • 18 Dec: @LuqiPan ran into this when trying to follow agoric-sdk/README.md

The cost to address this is mostly solving the circular buffer in flight-recorder.js which uses BufferFromFile which doesn’t work in Node 20 and seems to be no longer maintained

@turadg
Copy link
Member Author

turadg commented Feb 20, 2024

fixed in #8920

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working devex developer experience technical-debt triaged_2024
Projects
None yet
Development

No branches or pull requests

3 participants