This repository has been archived by the owner on May 3, 2024. It is now read-only.
chore: node 18 compat #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turadg
approved these changes
Jan 26, 2024
| @@ -13,7 +13,7 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| strategy: | |||
| matrix: | |||
| node-version: [14.x] | |||
| node-version: [18.x] | |||
There was a problem hiding this comment.
build (14.x) Expected — Waiting for status to be reported
Any ideas on how to get this to go away?
There was a problem hiding this comment.
someone with admin permissions on this repo has to change which CI status are Required to merge.
I'm sure @michaelfig has that permission. I don't know who else.
There was a problem hiding this comment.
I didn't have permission until just now, but now you should be unblocked.
0xpatrickdev
force-pushed
the
chore/node-compat
branch
from
961bf1f to
7343e98
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: Agoric/agoric-sdk#8636