Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agd reported incompatible with Ledger cosmos app #8783

Closed
mhofman opened this issue Jan 22, 2024 · 3 comments · Fixed by #8791
Closed

agd reported incompatible with Ledger cosmos app #8783

mhofman opened this issue Jan 22, 2024 · 3 comments · Fixed by #8791
Assignees
Labels
agd Agoric (Golang) Daemon agoric-cosmos bug Something isn't working

Comments

@mhofman
Copy link
Member

mhofman commented Jan 22, 2024

Describe the bug

Stakecito reported being unable to use the latest agd (currently at agoric-upgrade-13) with a Ledger, and provided a link to a PR on another cosmos project which also had the issue and solved it by bumping ledger-go related packages.

The issue as reported:

the latest ag0/agd* binary is not compatible with Ledger anymore. The dependencies have to be upgraded. Could the team please look into that?

txs do not work anymore with Ledger (e.g. tx authz). We just get an empty error:

confirm transaction before signing and broadcasting [y/N]: y
Error: 
Usage: 

To Reproduce

Steps to reproduce the behavior:

  1. e.g. agd tx authz using Ledger

Expected behavior

agd successfully signing tx using Ledger

Platform Environment

  • agoric-sdk at agoric-upgrade-13 release
  • Cosmos Ledger app at v2.34.12

Additional context

  • Fix for MacOS Sonoma Ledger detection issues #8462 is already bumping zondax/hid to v0.9.2, and scheduled for inclusion in agoric-upgrade-14.
  • We are currently using v0.14.1 of zondax/ledger-go, and the bump to v.0.14.3 seems to only be changing an error message and bumping the zondax/hid dep to v0.9.2.
  • We are currently using v0.12.2 of cosmos/ledger-cosmos-go and the bump to v0.12.3 seems to only be lowering the size of a message buffer, and bumping zondax/hid to v0.9.2
  • The changes to zondax/hid seem related only to MacOS detection issues

I suspect the actual fix is the message buffer size change in cosmos/ledger-cosmos-go. Regardless, updating these deps seems harmless.

@mhofman mhofman added bug Something isn't working agd Agoric (Golang) Daemon agoric-cosmos labels Jan 22, 2024
@mhofman mhofman assigned JimLarson and dckc and unassigned JimLarson Jan 22, 2024
@dckc
Copy link
Member

dckc commented Jan 23, 2024

I've got the ball on reproducing the problem using my spare Ledger (Ledger Nano S).

I updated the cosmos app to v2.34.12, as suggested by @mhofman .

p.s. problem reproduced and fix confirmed: #8798 (comment)

@mhofman mhofman assigned mhofman and unassigned dckc Jan 23, 2024
@mhofman mhofman assigned JimLarson and unassigned mhofman Jan 23, 2024
@mergify mergify bot closed this as completed in #8791 Feb 6, 2024
verabehr pushed a commit to palomachain/paloma that referenced this issue Feb 7, 2024
# Related Github tickets

- VolumeFi#1254
- Agoric/agoric-sdk#8783

# Background

Also see:
Agoric/agoric-sdk@bc4a284

# Testing completed

- [x] test coverage exists or has been added/updated
- [ ] tested in a private testnet

# Breaking changes

- [x] I have checked my code for breaking changes
- [x] If there are breaking changes, there is a supporting migration.
@JimLarson
Copy link
Contributor

Confirmed the fix with manual testing on current master.

@JimLarson
Copy link
Contributor

Confirmed the fix with manual testing of upgrade-14 rc0 on emerynet.

  • Hardware: Ledger NanoX V2.0
  • Firmware:
    • Secure Element 2.2.3
    • Microcontroller 2.30
    • Bootloader 1.16
  • Cosmos App: v2.34.12
# set up local config to point at emerynet
agd --home . keys add testledger0 --ledger --coin-type 118
# ledger sees request and approves
tl0=$(agd --home . keys show testledger0 -a)
# provision account via faucet
agd --home . keys add testledger1 --ledger --coin-type 118 --account 1
tl1=$(agd --home . keys show testledger1 -a)
agd --home . tx bank send $tl0 $tl1 1000ubld --from testledger0
# works, verified transfer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agd Agoric (Golang) Daemon agoric-cosmos bug Something isn't working
Projects
None yet
3 participants