-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
agd reported incompatible with Ledger cosmos app #8783
Labels
Comments
mhofman
added
bug
Something isn't working
agd
Agoric (Golang) Daemon
agoric-cosmos
labels
Jan 22, 2024
I've got the ball on reproducing the problem using my spare Ledger (Ledger Nano S). I updated the cosmos app to v2.34.12, as suggested by @mhofman . p.s. problem reproduced and fix confirmed: #8798 (comment) |
This was referenced Jan 23, 2024
4 tasks
verabehr
pushed a commit
to palomachain/paloma
that referenced
this issue
Feb 7, 2024
# Related Github tickets - VolumeFi#1254 - Agoric/agoric-sdk#8783 # Background Also see: Agoric/agoric-sdk@bc4a284 # Testing completed - [x] test coverage exists or has been added/updated - [ ] tested in a private testnet # Breaking changes - [x] I have checked my code for breaking changes - [x] If there are breaking changes, there is a supporting migration.
Confirmed the fix with manual testing on current |
Confirmed the fix with manual testing of upgrade-14 rc0 on emerynet.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Stakecito reported being unable to use the latest
agd
(currently atagoric-upgrade-13
) with a Ledger, and provided a link to a PR on another cosmos project which also had the issue and solved it by bumping ledger-go related packages.The issue as reported:
To Reproduce
Steps to reproduce the behavior:
agd tx authz
using LedgerExpected behavior
agd
successfully signing tx using LedgerPlatform Environment
agoric-sdk
atagoric-upgrade-13
releasev2.34.12
Additional context
zondax/hid
tov0.9.2
, and scheduled for inclusion inagoric-upgrade-14
.v0.14.1
ofzondax/ledger-go
, and the bump tov.0.14.3
seems to only be changing an error message and bumping thezondax/hid
dep tov0.9.2
.v0.12.2
ofcosmos/ledger-cosmos-go
and the bump tov0.12.3
seems to only be lowering the size of a message buffer, and bumpingzondax/hid
tov0.9.2
zondax/hid
seem related only to MacOS detection issuesI suspect the actual fix is the message buffer size change in
cosmos/ledger-cosmos-go
. Regardless, updating these deps seems harmless.The text was updated successfully, but these errors were encountered: