Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When upgrading Zoe on chain, revive KREAd subscribers #8837

Closed
Chris-Hibbert opened this issue Jan 29, 2024 · 0 comments · Fixed by #8853
Closed

When upgrading Zoe on chain, revive KREAd subscribers #8837

Chris-Hibbert opened this issue Jan 29, 2024 · 0 comments · Fixed by #8853
Assignees
Labels
contract-upgrade enhancement New feature or request Zoe package: Zoe

Comments

@Chris-Hibbert
Copy link
Contributor

Chris-Hibbert commented Jan 29, 2024

What is the Problem Being Solved?

When Zoe is upgraded, various promises held by the KREAd contract will break.

Description of the Design

According to #8714, the promises can be repaired by calling the reviveMarketExitSubscribers method on the KREAd contract's creatorFacet.

This ticket says to invoke that method when upgrading Zoe in upgrade14 or upgrade15.

Security Considerations

Keep customer contracts working.

Scaling Considerations

Not pertinent.

Test Plan

#8714 established that the method is there. We should add a test in a3p-integration to show that the KREAd contract continues to function.

Upgrade Considerations

Upgrading shouldn't break things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contract-upgrade enhancement New feature or request Zoe package: Zoe
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants