feat: repair KREAd contract on zoe upgrade #8853
Conversation
There was a problem hiding this comment.
You need to include the revive kread script in the list of core proposal steps to execute during the upgrade, after Zoe upgrade here:
agoric-sdk/golang/cosmos/app/app.go
Lines 837 to 838 in e052586
| const creatorFacet = kreadKit.creatorFacet; | ||
| console.log(`KREAd creatorFacet`, creatorFacet); | ||
| await E(creatorFacet).reviveMarketExitSubscribers(); | ||
| console.log('success!'); |
There was a problem hiding this comment.
Please use a more descriptive message. This will be mixed with other bootstrap vat logging
Chris-Hibbert
force-pushed
the
8837-kread-postZoeUpgrade
branch
from
adc4f87
to
1f982b6
Compare
|
I've now added a test showing a KREAd character purchase. |
mhofman
force-pushed
the
mhofman/upgrade-zoe-zcf
branch
from
e052586
to
40407e9
Compare
| export const defaultProposalBuilder = async () => | ||
| harden({ | ||
| sourceSpec: '@agoric/vats/src/proposals/kread-proposal.js', | ||
| getManifestCall: ['getManifestForKread', harden({})], |
There was a problem hiding this comment.
Unnecessary nested harden.
| getManifestCall: ['getManifestForKread', harden({})], | |
| getManifestCall: ['getManifestForKread', {}], |
But for that matter, this argument is ignored by packages/vats/src/proposals/kread-proposal.js getManifestForKread anyway and should itself be unnecessary.
| getManifestCall: ['getManifestForKread', harden({})], | |
| getManifestCall: ['getManifestForKread'], |
| // eslint-disable-next-line no-use-before-define | ||
| watchForAdminNodeDone(adminNode, instanceAdmin); |
There was a problem hiding this comment.
I'd prefer watchForAdminNodeDone to be part of the watcher for less circularity, but this does work.
There was a problem hiding this comment.
It's a separate function because it's called from other places outside the watcher.
mhofman
force-pushed
the
8837-kread-postZoeUpgrade
branch
from
e01012d
to
cb20dc9
Compare
closes: #8837
Description
Invoke KREAd's revive
Security Considerations
negligible
Scaling Considerations
None
Documentation Considerations
None
Testing Considerations
Needs to be tested. I think doing any KREAd transaction after the upgrade demonstrates success.
Upgrade Considerations
#8714 showed that a Zoe upgrade would break promises that the KREAd contract depends on. We expect
creatorFacet.reviveMarketExitSubscribers();to reconnect to the relevant promises.