Write a coreEval to upgrade Vaults in Upgrade-15 #8981
Assignees
Labels
Comments
Chris-Hibbert
added
enhancement
Merged
mergify bot
added a commit
that referenced
this issue
Aug 13, 2024
_incidental_ ## Description Refactors the auction amount math out of the auction book and adds unit tests. I noticed an inconsistency so this adds an assertion to prevent that and a fix. Also a bunch of refactorings and docs to try to make this area of the code more clear. Reviewers, review by commit is recommended. ### Security Considerations The auction book now calls out to another module to do the math. Module from its own package though. ### Scaling Considerations no change ### Documentation Considerations not user facing ### Testing Considerations regression test ### Upgrade Considerations This won't go out until VaultFactory gets a new auctioneer. See, - #8735 - #8981 @Chris-Hibbert is working on the CoreEval and its test to deploy this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is the Problem Being Solved?
Vaults should be upgraded in Upgrade-15. This relies on new priceFeeds, and a new AuctionContract.
See #8740 for the overall plan for upgrading price feeds, of which this is a part.
Description of the Design
When Vaults are upgraded, they must be informed of the new priceAuthority and the new Auction.
Security Considerations
none
Scaling Considerations
This is in service of resolving some sustainability challenges caused by the old price feeds
Test/Upgrade Plan
Verify in a3p-integration that everything is happy afterwards.
The text was updated successfully, but these errors were encountered: