agd tx submit-proposal upgrade-info must pass new CLI validation code

[aj-agoric]

What is the Problem Being Solved?

OpCo need to support the new validation done in the CLI of software-upgrade gov proposals.

While an issue exists upstream with the parsing of the upgrade-info, it doesn't trigger for upgrade info values that contain valid binaries urls.

However the new cosmos CLI validation verifies the URLs point to valid artifacts.

Description of the Design

Change the upgrade-info generation instructions (and script) to

• modify upgrade-info.binaries.any to include a //agoric-sdk-$COMMIT_ID suffix between the .zip and the ?checksum. This is a trick for go-getter to unpack the top level folder of the GitHub archive.
• add a upgrade-info.source to be the previous value of the upgrade-info.binaries.any (without the suffix above), to support 3rd party downloaders which do not understand the go-getter trick.

Security Considerations

None

Scaling Considerations

None

Test Plan

• a3p adhoc test: agorictest-upgrade-14 agoric-3-proposals#120 (does not need to be merged)

Upgrade Considerations

ability to upgrade to new software

[gibson042]

PR: agoric-labs/cosmos-sdk#405

[mhofman]

The forum posts were updated to reflect the above, and for the upgrade-14 branch, we did change the gen script as well (f091b6d). A similar change for the master branch should be implemented, maybe while doing #8784

[gibson042]

This was fixed for upgrade-14 by 32bff4b#diff-212b769d9a514d2e7813277e574999c609023d1d27de8d7b11244b879a81db3e as part of #9041, and is being tracked for later releases by #9105.