refine net-ibc upgrade tests for non-happy paths #9631
Labels
Comments
mergify bot
added a commit
that referenced
this issue
Jul 1, 2024
refs: #9308 ## Description - adds `asPromise` helper to `VowTools` for unwrapping `Vow|Promise`, ensuring proper handling of ephemeral promises - updates watch-utils to better handle values that are not storable durably, such as promises ### Testing Considerations This does not include tests that simulate an upgrade - only a heap zone is used in the included tests. See #9631 ### Upgrade Considerations This PR includes changes we'd like to be in the initial release of vows.
gibson042
pushed a commit
that referenced
this issue
Jul 2, 2024
refs: #9308 ## Description - adds `asPromise` helper to `VowTools` for unwrapping `Vow|Promise`, ensuring proper handling of ephemeral promises - updates watch-utils to better handle values that are not storable durably, such as promises ### Testing Considerations This does not include tests that simulate an upgrade - only a heap zone is used in the included tests. See #9631 ### Upgrade Considerations This PR includes changes we'd like to be in the initial release of vows.
gibson042
added a commit
that referenced
this issue
Jul 2, 2024
refs: #9308 ## Description - adds `asPromise` helper to `VowTools` for unwrapping `Vow|Promise`, ensuring proper handling of ephemeral promises - updates watch-utils to better handle values that are not storable durably, such as promises ### Testing Considerations This does not include tests that simulate an upgrade - only a heap zone is used in the included tests. See #9631 ### Upgrade Considerations This PR includes changes we'd like to be in the initial release of vows.
gibson042
pushed a commit
that referenced
this issue
Jul 2, 2024
refs: #9308 ## Description - adds `asPromise` helper to `VowTools` for unwrapping `Vow|Promise`, ensuring proper handling of ephemeral promises - updates watch-utils to better handle values that are not storable durably, such as promises ### Testing Considerations This does not include tests that simulate an upgrade - only a heap zone is used in the included tests. See #9631 ### Upgrade Considerations This PR includes changes we'd like to be in the initial release of vows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is the Problem Being Solved?
We're working on a fix to vows that could / should have been caught by an elaboration of
net-ibc-upgrade.test.ts to check more "non-happy" paths.
Design / Test Plan
Elaborate the test to expose the flaw that @turadg is fixing.
Security / Scaling Considerations
n/a
Upgrade Considerations
only tangential, in that the relevant fix is very much motivated by upgrade stuff
cc @LuqiPan @michaelfig @0xpatrickdev @turadg
The text was updated successfully, but these errors were encountered: