Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

well-known interchain denoms should be registered as vbank assets in multichain-testing environment #9966

Closed
1 task
0xpatrickdev opened this issue Aug 26, 2024 · 0 comments · Fixed by #10591
Closed
1 task

well-known interchain denoms should be registered as vbank assets in multichain-testing environment #9966

0xpatrickdev opened this issue Aug 26, 2024 · 0 comments · Fixed by #10591
Assignees
@0xpatrickdev
Labels
enhancement New feature or request

Comments

@0xpatrickdev
Copy link
Member

0xpatrickdev commented Aug 26, 2024 •
edited
Loading

What is the Problem Being Solved?

As an orchestration developer, I should be able to use well-known interchain assets in zoe offers as a Give or Want and a Payment.

Description of the Design

Dependencies
Beta Give feedback
  1. fetch assetlist info into agoricNames #9752
    enhancement needs-design
    turadg

  • The multichain-testing environment should support offers with the native tokens of chains running in CI (uatom, uosmo, uion). This likely requires:

    • updates to multichain-testing/scripts/fetch-starship-chain-info.ts, to query the observed denoms of the environment
    • a proposal that does something along the lines of publishInterchainAssetFromBank, as part of proposals/revise-chain-info.js or a separate proposal

  • Existing denom mappings, like ATOM -> ibc/toyatom should be overridden to resolve to the correct denom

Security Considerations

Scaling Considerations

Test Plan

Upgrade Considerations
@0xpatrickdev 0xpatrickdev added the enhancement New feature or request label Aug 26, 2024
This was referenced Aug 26, 2024
Open
Open
This was referenced Sep 19, 2024
Closed
Merged
mergify bot added a commit that referenced this issue Sep 20, 2024
@mergify
feat(localOrchAccount): Deposit, Withdraw invitationMakers (#10117)
c04c91c 
refs: #9193

## Description
Adds `Deposit` and `Withdraw` invitationMakers to `LocalOrchestrationAccount`, leveraging `ZoeTools.localTransfer` and `ZoeTools.withdrawToSeat`

### Security Considerations
Involves withdrawing payments to a temporary seat, which can be risky.  Leverages `ZoeTools` which rolls back allocations in failure and partial failure scenarios.

### Scaling Considerations
n/a

### Documentation Considerations
I'm not sure how well we document the platform-provided `invitationMakers` and `.asContinuingOffer()` helper. We might consider doing so in the future.

### Testing Considerations
Includes new unit tests. Wallet Driver tests in an e2e environment are coming in a future PR after #9966 lands

### Upgrade Considerations
n/a, library code
@0xpatrickdev 0xpatrickdev self-assigned this Sep 20, 2024
@0xpatrickdev 0xpatrickdev mentioned this issue Nov 11, 2024
Open
@0xpatrickdev 0xpatrickdev mentioned this issue Dec 1, 2024
Merged
@mergify mergify bot closed this as completed in #10591 Dec 4, 2024
@mergify mergify bot closed this as completed in cf1d435 Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0xpatrickdev 0xpatrickdev

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: send-anywhere pfm scenarios Agoric/agoric-sdk
3 participants
@0xpatrickdev and others