use particular fromTag in a3p-integration #10056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
32163ea
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c171fc0d.agoric-sdk.pages.dev |
| Branch Preview URL: | https://ta-a3p-use-particular.agoric-sdk.pages.dev |
mhofman
approved these changes
Sep 10, 2024
a3p-integration/proposals/README.md
Outdated
Comment on lines
81
to
83
| Once a new proposal is merged into agoric-3-proposals, take the proposal name | ||
| (the part after the colon) and make it the fromTag value in a3p-integration's | ||
| package.json. |
There was a problem hiding this comment.
make it the fromTag value
This might be a little confusing since the tag would actually be formed as use-${proposalName}
| If you're changing the fromTag to a a new SDK version (e.g. a new chain-halting | ||
| upgrade) then you also need to revise the `upgrade-next` proposal to be able to | ||
| apply on top of that upgrade. In master it should already have these values, | ||
| which should be maintained: |
They are lexically ordered but there are enough letters in the alphabet that we can make them easier to remember. In particular "n" for next upgrade.
turadg
force-pushed
the
ta/a3p-use-particular
branch
from
6b4389a to
32163ea
Compare
turadg
added
bypass:automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
incidental
Description
Use a particular fromTag to avoid build errors when agoric-3-proposals advances
latest.Also changes the proposal id for
upgrade-nextfrometonto make it easier to remember, give ample namespace preceding it and make it very obvious from a proposal ID that it's after the next upgrade. E.g.s:stake-bld(which had beeng:stake-bld)Security Considerations
n/a
Scaling Considerations
n/a
Documentation Considerations
Updated docs here. Agoric/agoric-3-proposals#180 should align.
Testing Considerations
CI
Upgrade Considerations
n/a