chore: normalize chain info #10109
Draft
chore: normalize chain info #10109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- counterParty -> counterparty - prefer camelCase to snake_case for JS conventions - prefer flattened counterparty fields (counterpartyConnectionId)
Deploying agoric-sdk with
|
| Latest commit: |
98e4e9b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3ddb5c92.agoric-sdk.pages.dev |
| Branch Preview URL: | https://9807-normalize-chain-info.agoric-sdk.pages.dev |
dckc
reviewed
Sep 18, 2024
| denom_units: [ | ||
| denomUnits: [ |
There was a problem hiding this comment.
This was sourced from the chain registry. I don't think it's cost-effective to be different.
There was a problem hiding this comment.
never mind.
looks like we're already tweaking such names.
portId: channelFrom.port_id,
dckc
approved these changes
Sep 18, 2024
mergify bot
added a commit
that referenced
this pull request
Sep 18, 2024
_incidental_ ## Description We don't have a good design yet for the schema of Orchestration chain info in agoricNames, - #10109 It's not necessary for upgrade-17 so save it for another proposal. ### Security Considerations none ### Scaling Considerations none ### Documentation Considerations SDK still registers the info so the development experience doesn't differ. ### Testing Considerations Shouldn't break any existing tests. ### Upgrade Considerations Not yet deployed. Should be part of u17-rc1.
gibson042
pushed a commit
that referenced
this pull request
Sep 19, 2024
_incidental_ ## Description We don't have a good design yet for the schema of Orchestration chain info in agoricNames, - #10109 It's not necessary for upgrade-17 so save it for another proposal. ### Security Considerations none ### Scaling Considerations none ### Documentation Considerations SDK still registers the info so the development experience doesn't differ. ### Testing Considerations Shouldn't break any existing tests. ### Upgrade Considerations Not yet deployed. Should be part of u17-rc1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #9807
Description
Normalizes chain info for agoricNames:
Security Considerations
n/a
Scaling Considerations
n/a
Documentation Considerations
n/a
Testing Considerations
Existing tests updated as this is just a rename.
Upgrade Considerations
Will require a proposal to update this data if this doesn't land in u17