simplify and finish unbond example #10121
Conversation
Deploying agoric-sdk with
|
| Latest commit: |
58e38a2
|
| Status: | 🚫 Build failed. |
| // TODO https://github.com/Agoric/agoric-sdk/issues/10017 | ||
| // await strideAccount.liquidStake(tiaAmt); | ||
| console.log(osmoAccount, strideAccount); | ||
| const balance = await osmoAccount.getBalance('OSMO'); |
There was a problem hiding this comment.
OSMO works, and it doesn't need to be uosmo? Maybe grab stakingTokens[0] from chainInfo?
There was a problem hiding this comment.
L20 // In a real world scenario, accounts would be re-used across invocations of the handler
Since #9796 is closed, and this PR will close 9782, can I request this is written as a continuing invitation? This would allow us to test in multichain-testing and improve the fidelity of our example contracts
turadg
force-pushed
the
9782-unbond-example
branch
from
e83725e
to
923dca3
Compare
Settled on a comment that points the reader to staking-combinations for an example of what I was asking for |
turadg
force-pushed
the
9782-unbond-example
branch
from
923dca3
to
5951f29
Compare
turadg
force-pushed
the
9782-unbond-example
branch
from
5951f29
to
58e38a2
Compare
|
@mergify requeue |
☑️ This pull request is already queued |
|
oh crud... I'm too slow to note the examples README should be updated: agoric-sdk/packages/orchestration/src/examples/README.md Lines 9 to 14 in 741bbd1 |
incidental ## Description Cleans up the README per #10121 (comment) I thought that was too light a PR so it also bumps typescript-eslint (not quite latest because that OOMs: #10120) Then I remember there are a couple filenames to normalize in examples this does that too. ### Security Considerations n/a ### Scaling Considerations n/a ### Documentation Considerations Improved ### Testing Considerations CI ### Upgrade Considerations not deployed
closes: #9782
Description
#9782 was to finish the example of "unbond and liquidate". We've punted Liquid Staking,
LiquidStakingMethodsinterface #10017So to get a complete working example this does a transfer after unbonding.
Security Considerations
Not being deployed
Scaling Considerations
Not being deployed
Documentation Considerations
May become part of documentation, up to DevRel
Testing Considerations
CI
Upgrade Considerations
Not being deployed