-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add strict liveslots test env with upgrade tools #10126
Open
mhofman
wants to merge
13
commits into
master
Choose a base branch
from
mhofman/9126-higher-fidelity-fake-liveslots
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with Cloudflare Pages
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #9126
Best reviewed commit-by-commit
Description
This PR add a new
prepare-strict-test-env.js
which enforces durable requirements on the baggage and provide helpers to simulate upgrades based on the helper from theasync-flow
andzone
package tests.In particular it adds a new
startLife
helper which enforces kind redefinition rules for abuild
step, and rejects previously watched promises (assuming they were all decided by the previous incarnation).Security Considerations
None, test infra only
Scaling Considerations
None
Documentation Considerations
Some types added and clarified. Internal tooling
Testing Considerations
Adds tests of the new strict env and
startLife
helper.Add liveslots based test in
vow
using the newstartLife
helper.Updated the test environments in the
zone
andasync-flow
package to use the new liveslots env, but does not update theasync-flow
tests to use the stricterstartLife
(will be done in #9933 or #9383)Upgrade Considerations
Better upgrade testing without needing a full swingset kernel