Add strict liveslots test env with upgrade tools #10126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
9300ae8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e6c7a440.agoric-sdk.pages.dev |
| Branch Preview URL: | https://mhofman-9126-higher-fidelity.agoric-sdk.pages.dev |
michaelfig
approved these changes
Sep 24, 2024
packages/swingset-liveslots/test/virtual-objects/virtualObjectManager.test.js
Outdated
Show resolved
Hide resolved
| export const reincarnate = (options = {}) => { | ||
| const { fakeStore = new Map(), fakeVomKit: fvk } = options; | ||
| /** | ||
| * @typedef {import("@agoric/internal").Simplify<Omit<NonNullable<Parameters<typeof makeFakeVirtualStuff>[0]>, 'WeakMap' | 'WeakSet'> & {fakeVomKit: FakeVomKit; fakeStore: Map<string, string>}>} ReincarnateOptions |
There was a problem hiding this comment.
Could you please add some newlines in this typedef? I can't easily see which parts are nested under which other parts.
| baggage => { | ||
| const zone = makeDurableZone(baggage, 'durableRoot'); | ||
| prepareVowTools(zone); | ||
| zone.exo('DurableVowTestWatcher', undefined, { |
There was a problem hiding this comment.
Did you mean to do something with this watcher? It seems just to be dropped on the floor.
Suggested change
| zone.exo('DurableVowTestWatcher', undefined, { | |
| const watcher = zone.exo('DurableVowTestWatcher', undefined, { |
There was a problem hiding this comment.
The behavior is redefined. This singleton exo is already setup as watcher in the previous incarnation, so we don't care about its identity here, just that a behavior is reconnected when invoked when resolving the vow.
Added a comment.
mhofman
force-pushed
the
mhofman/9126-higher-fidelity-fake-liveslots
branch
from
dcd5441 to
9300ae8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #9126
Best reviewed commit-by-commit
Description
This PR add a new
prepare-strict-test-env.jswhich enforces durable requirements on the baggage and provide helpers to simulate upgrades based on the helper from theasync-flowandzonepackage tests.In particular it adds a new
startLifehelper which enforces kind redefinition rules for abuildstep, and rejects previously watched promises (assuming they were all decided by the previous incarnation).Security Considerations
None, test infra only
Scaling Considerations
None
Documentation Considerations
Some types added and clarified. Internal tooling
Testing Considerations
Adds tests of the new strict env and
startLifehelper.Add liveslots based test in
vowusing the newstartLifehelper.Updated the test environments in the
zoneandasync-flowpackage to use the new liveslots env, but does not update theasync-flowtests to use the stricterstartLife(will be done in #9933 or #9383)Upgrade Considerations
Better upgrade testing without needing a full swingset kernel