-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build proposals for PriceFeed coreEvals on multiple platforms. #10146
Conversation
Are these included in the artifacts produced in ci as part of #9929 ? Looks like test-docker-build was Skipped. Want to add force-integration? Should I? |
No, but I can add that.
This doesn't change anything that would effect that, I think. Why would that be helpful? |
Deploying agoric-sdk with Cloudflare Pages
|
based on ci gripes, it looks like we need to
|
Okay, that took a couple of tries, but it's not complaining now. |
I grabbed the core-eval-scripts.zip from the ci job. I see just 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as we discussed, gov-price-feeds-${config}
should help
The strings in the package.json have changed. See this comment. |
bf1bd0c
to
eb941d4
Compare
790be81
to
ed703d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not doing what I would expect.
a3p-integration/package.json
Outdated
@@ -4,9 +4,11 @@ | |||
"fromTag": "use-vaults-auctions" | |||
}, | |||
"scripts": { | |||
"build": "yarn run build:sdk && yarn run build:submissions && yarn run build:synthetic-chain", | |||
"build": "yarn run build:sdk && yarn run build:submissions && yarn run build:synthetic-chain && yarn run build:priceFeeds-for-mainnet && yarn run build:priceFeeds-for-devnet", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see only the 1 variant in the ci job Artifact:
$ unzip -l core-eval-scripts.zip |grep gov-price
1024 2024-10-10 01:41 f-replace-price-feeds/gov-price-feeds-A3P_INTEGRATION-permit.json
1463 2024-10-10 01:41 f-replace-price-feeds/gov-price-feeds-A3P_INTEGRATION-plan.json
7069 2024-10-10 01:41 f-replace-price-feeds/gov-price-feeds-A3P_INTEGRATION.js
Is build:submissions
the relevant thing to tweak rather than build
?
@@ -6,7 +6,9 @@ | |||
"scripts": { | |||
"build": "yarn run build:sdk && yarn run build:submissions && yarn run build:synthetic-chain", | |||
"build:sdk": "make -C ../packages/deployment docker-build-sdk", | |||
"build:submissions": "scripts/build-all-submissions.sh", | |||
"build:submissions": "scripts/build-all-submissions.sh && yarn run build:priceFeeds-for-mainnet && yarn run build:priceFeeds-for-devnet", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems to work!
$ unzip -l core-eval-scripts.zip |grep gov-price
1436 2024-10-10 21:15 f-replace-price-feeds/devnet/gov-price-feeds-devnet-plan.json
1024 2024-10-10 21:15 f-replace-price-feeds/devnet/gov-price-feeds-devnet-permit.json
7195 2024-10-10 21:15 f-replace-price-feeds/devnet/gov-price-feeds-devnet.js
1024 2024-10-10 21:15 f-replace-price-feeds/gov-price-feeds-A3P_INTEGRATION-permit.json
1463 2024-10-10 21:15 f-replace-price-feeds/gov-price-feeds-A3P_INTEGRATION-plan.json
7069 2024-10-10 21:15 f-replace-price-feeds/gov-price-feeds-A3P_INTEGRATION.js
1024 2024-10-10 21:15 f-replace-price-feeds/main/gov-price-feeds-main-permit.json
1430 2024-10-10 21:15 f-replace-price-feeds/main/gov-price-feeds-main-plan.json
7284 2024-10-10 21:15 f-replace-price-feeds/main/gov-price-feeds-main.js
closes: #10076
refs: #10074
Description
Build platform-dependent proposals for the PriceFeed coreEval.
For each platform (not counting A3P) defined in
updatePriceFeeds.js
, a command is added, which invokesscripts/build-submission.sh
three times to build each of the required proposals (updatePriceFeeds.js, add-auction.js, and upgradeVaults.js). The invocation for updatePriceFeeds takes a parameter specifying the platform.Security Considerations
N/A
Scaling Considerations
N/A
Documentation Considerations
Not user-visible
Testing Considerations
test on DevNet and MainFork
Upgrade Considerations
It's all about upgrade. This coreEval has code that varies depending on the collaterals and oracles present, so we have to build separate proposals for each platform.