-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(a3p): extend coverage of KREAd app on z:acceptance test phase #10212
Closed
Jorge-Lopes
wants to merge
11
commits into
Agoric:master
from
bytepitch:jorge/acceptance-kread-tests
Closed
test(a3p): extend coverage of KREAd app on z:acceptance test phase #10212
Jorge-Lopes
wants to merge
11
commits into
Agoric:master
from
bytepitch:jorge/acceptance-kread-tests
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since this PR hasn't undergone the review process yet, I’ve decided to close it for the following reasons:
I’ll be submitting a new PR shortly, following the correct workflow and ensuring a clean commit history. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: https://github.com/Agoric/BytePitchPartnerEng/issues/13
refs: https://github.com/Agoric/BytePitchPartnerEng/issues/9
refs: #10049
Description
The existing test of the
KREAd
application on thez:acceptance
test phase was limited to the feature allowing users tomint
a new KREAd Character.This PR extends the existing test coverage to include the following cases:
Along with the
kread.test.js
file, this PR includes a new file,/test-lib/kread.js
, that provides all the requiredhelper functions
for the test cases above, allowing a cleaner and scalable design for KREAd tests.Since the test coverage of the new file overlaps with the existing one, I opted for removing both:
Security Considerations
No security considerations were identified.
Scaling Considerations
No scaling considerations were identified.
Documentation Considerations
No documentation considerations were identified.
Testing Considerations
I have confirmed that this works fine with existing a3p tests locally, there is still an improvement that may be useful to ensure that the user wallet's purse balance for the desired KREAd asset was updated accordingly.
For this purpose, we intend to use one feature included in the currently open PR #10171 , which is the sync-tools method
retryUntilCondition()
.However, we hope to address those changes in a different PR that will be the result of the effort put into the currently open ticket